Protovalidate interceptor cleanup, Go version bump #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2k
force-pushed
the
protovalidate-cleanup
branch
4 times, most recently
from
19af624
to
839d345
Compare
ash2k
changed the title
|
Follow up questions:
|
johanbrandhorst
requested changes
Aug 16, 2024
| // UnaryServerInterceptor returns a new unary server interceptor that validates incoming messages. | ||
| // If the request is invalid, clients may access a structured representation of the validation failure as an error detail. | ||
| func UnaryServerInterceptor(validator *protovalidate.Validator, opts ...Option) grpc.UnaryServerInterceptor { | ||
| func UnaryServerInterceptor(validator Validator, opts ...Option) grpc.UnaryServerInterceptor { |
There was a problem hiding this comment.
This is actually a breaking change, and I'm not sure we need to make this change? If you want to propose this, please open an issue. If you remove this change I'm happy to merge the rest of this PR.
No, I'd rather users create their own interceptors for this sort of thing.
For outgoing requests? For responses from servers? Not sure where that would go. |
According to https://github.com/grpc-ecosystem/go-grpc-middleware?tab=readme-ov-file#prerequisites, three latest versions are supported. Go 1.23 is out, so we can bump minimum required version to 1.21 and start using "slices" and "log/slog" from stdlib.
ash2k
force-pushed
the
protovalidate-cleanup
branch
from
839d345
to
a415b61
Compare
|
Thanks for your contribution! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please see individual commits.
Verification
Unit tests. No significant changes.