Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go version support policy? #717

Open
akshayjshah opened this issue May 25, 2024 · 3 comments
Open

Go version support policy? #717

akshayjshah opened this issue May 25, 2024 · 3 comments

Comments

@akshayjshah
Copy link
Contributor

Does this repository have an explicit policy on Go version support? I notice that CI is only testing on Go 1.19 and 1.20, neither of which is still receiving security patches. At this point, testing on 1.19 is beginning to block some version updates.

Would it be okay if I opened a PR updating to the latest versions of the various Github actions and changing CI to test on stable and oldstable? They were introduced relatively recently in the setup-go as aliases for the two currently-supported versions of Go.

@johanbrandhorst
Copy link
Collaborator

Using stable and oldstable sounds ideal to me :). Please feel free to submit a PR!

@ash2k
Copy link
Contributor

ash2k commented Aug 17, 2024

Go version support is documented here: https://github.com/grpc-ecosystem/go-grpc-middleware?tab=readme-ov-file#prerequisites

I've just bumped the minimum version to 1.21 and added 1.22 and 1.23 to CI in #721. Did I miss something or we can close this issue?

@johanbrandhorst
Copy link
Collaborator

This issue is newer than the existing policy, it might be nice to switch to just stable and oldstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants