Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.0 #888

Merged
merged 7 commits into from
Jan 10, 2024
Merged

Release 2.2.0 #888

merged 7 commits into from
Jan 10, 2024

Conversation

ialokim
Copy link
Collaborator

@ialokim ialokim commented Nov 12, 2023

Here are the steps to follow when preparing a new release (some custom tasks added for this release). Please check the following boxes with an x when done:

Please also refer to #689 as an example.

@cla-bot cla-bot bot added the cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors. label Nov 12, 2023
@ialokim ialokim changed the title Prepare release 2.v2 Prepare release 2.2.0 Nov 12, 2023
@ialokim
Copy link
Collaborator Author

ialokim commented Nov 14, 2023

  • fix any bugs if necessary

several issues reported: #889 #890 https://gitlab.com/opentransitmap/public-transport-enabler/-/issues/6

In order to get the release out soon, I'd consider them as being non-release-blocking.

@Altonss
Copy link
Collaborator

Altonss commented Nov 14, 2023

  • fix any bugs if necessary

several issues reported: #889 #890 https://gitlab.com/opentransitmap/public-transport-enabler/-/issues/6

In order to get the release out soon, I'd consider them as being non-release-blocking.

Indeed, #889 and #890 don't seem to be new issues related to this release.

@M00NJ
Copy link

M00NJ commented Nov 14, 2023

Could #872 be a part of this release as well?

@ialokim
Copy link
Collaborator Author

ialokim commented Nov 14, 2023

Could #872 be a part of this release as well?

I don't think this is a good idea, given that we want to publish the release soon, and #872 brings a lot of UI changes that need a thourough testing.

@Altonss
Copy link
Collaborator

Altonss commented Dec 5, 2023

Tested this 2.2.0 release branch, and didn't encounter any issue! Great job @ialokim 👏
I think the new version could be released soon :)

@Altonss
Copy link
Collaborator

Altonss commented Dec 5, 2023

For the changelog I suggest something like:

- Switch to new map library (maplibre).
- Fix bugs: remember preferred means of transport, fix blank `About > Libraries` page.
- Update PTE data library: transport networks fixes and removals.
- Remove following networks: Finland, Portugal, Hungary, Czech Republic, Ghana, California, Oregon, New York, Ontario, Quebec, British Colombia, Costa Rica, Nicaragua, Florianópolis (Brazil), Brazil, New Zealand.
- Disable temporarily broken endpoints: VOR, STV, VVV and WienerLinien (Austria), Belgium, 9292 (Netherlands).

@mesinger
Copy link
Contributor

mesinger commented Jan 7, 2024

@ialokim any way i can help to get this release done?

@ialokim ialokim marked this pull request as ready for review January 7, 2024 21:58
@ialokim ialokim requested review from grote and Altonss January 7, 2024 21:59
@ialokim ialokim changed the title Prepare release 2.2.0 Release 2.2.0 Jan 7, 2024
Copy link
Collaborator

@Altonss Altonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work @ialokim! Everything looks fine to me!
A few general comments (aside from those in the code):

<release
version="2.2.0"
versioncode="124">
<change>Switch map library to MapLibre - finally bringing Transportr back to F-Droid!</change>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, we didn't make it back, yet ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's the next unchecked bullet point in the first post, but we cannot continue without tagging the release :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we will make it back (I hope)! 😄

@ialokim
Copy link
Collaborator Author

ialokim commented Jan 8, 2024

Thanks for your review @Altonss!

* [ ]  Why updating strings for pl network navitia that is for now removed? IMHO it clutters a bit the PR with useless strings.

There are a lot of leftover strings from now removed regions which should probably be cleaned properly at some point. But you are right, those are unfortunately really useless. I've removed them now manually.

* [ ]  Shouldn't we also mention in the changelogs that we've re-added VRS?

Good catch, added that!

Copy link
Collaborator

@Altonss Altonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Altonss
Copy link
Collaborator

Altonss commented Jan 9, 2024

Ready to merge and tag the release?

@grote grote merged commit 8d1afc4 into master Jan 10, 2024
4 checks passed
@grote grote deleted the release-2.2 branch January 10, 2024 17:05
@grote
Copy link
Owner

grote commented Jan 10, 2024

Thanks everyone who contributed to this release. You are awesome! :D

I just pressed the button and the release is out. However, Google Play doesn't accept it: Google Api Error: Invalid request - Target SDK of artifact is too low: 124. It seems it is currently 32 which won't work anymore. Please see https://support.google.com/googleplay/android-developer/answer/11926878 for details.

@Altonss
Copy link
Collaborator

Altonss commented Jan 10, 2024

I just pressed the button and the release is out. However, Google Play doesn't accept it: Google Api Error: Invalid request - Target SDK of artifact is too low: 124. It seems it is currently 32 which won't work anymore. Please see https://support.google.com/googleplay/android-developer/answer/11926878 for details.

That shouldn't be too hard to fix, I'll try to do it :)

@Altonss
Copy link
Collaborator

Altonss commented Jan 10, 2024

@grote Target SDK issue should be fixed with #910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switzerland: SBB Not work.
5 participants