Ensure parsing a serialized LogQL AST results in the same AST.

pkg/logql/syntax/parser_test.go

@@ -2007,6 +2007,30 @@ var ParseTestCases = []struct {
 			OpRangeTypeQuantile, &Grouping{Without: false, Groups: []string{"namespace", "instance"}}, NewStringLabelFilter("0.99998"),
 		),
 	},
+	{
+		in: `{app="foo"} | json | size >= 2.56GiB `,
+		exp: &PipelineExpr{
+			Left: newMatcherExpr([]*labels.Matcher{{Type: labels.MatchEqual, Name: "app", Value: "foo"}}),
+			MultiStages: MultiStageExpr{
+				newLabelParserExpr(OpParserTypeJSON, ""),
+				&LabelFilterExpr{
+					LabelFilterer: log.NewBytesLabelFilter(log.LabelFilterGreaterThanOrEqual, "size", 2_748_779_070),
+				},
+			},
+		},
+	},
+	{
+		in: `{app="foo"} | json | duration >= 3s15ms`,
+		exp: &PipelineExpr{
+			Left: newMatcherExpr([]*labels.Matcher{{Type: labels.MatchEqual, Name: "app", Value: "foo"}}),
+			MultiStages: MultiStageExpr{
+				newLabelParserExpr(OpParserTypeJSON, ""),
+				&LabelFilterExpr{
+					LabelFilterer: log.NewDurationLabelFilter(log.LabelFilterGreaterThanOrEqual, "duration", 3_015_000_000),
+				},
+			},
+		},
+	},
 	{
 		in: `sum without (foo) (
 				quantile_over_time(0.99998,{app="foo"} |= "bar" | json | latency >= 250ms or ( status_code < 500 and status_code > 200)
@@ -3146,6 +3170,12 @@ func TestParse(t *testing.T) {
 			ast, err := ParseExpr(tc.in)
 			require.Equal(t, tc.err, err)
 			require.Equal(t, tc.exp, ast)
+
+			if err == nil {
+				roundtrip, err := ParseExpr(ast.String())
+				require.NoError(t, err)
+				require.Equal(t, ast, roundtrip)
+			}
 		})
 	}
 }

pkg/logql/syntax/serialize_test.go

@@ -2,7 +2,6 @@ package syntax
 
 import (
 	"bytes"
-	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -74,9 +73,6 @@ func TestJSONSerializationParseTestCases(t *testing.T) {
 			t.Run(tc.in, func(t *testing.T) {
 				ast, err := ParseExpr(tc.in)
 				require.NoError(t, err)
-				if strings.Contains(tc.in, "KiB") {
-					t.Skipf("Byte roundtrip conversion is broken. '%s' vs '%s'", tc.in, ast.String())
-				}
 
 				var buf bytes.Buffer
 				err = EncodeJSON(ast, &buf)