-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure parsing a serialized LogQL AST results in the same AST. #11227
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 91cdb6c - Browse repository at this point
Copy the full SHA 91cdb6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90638b4 - Browse repository at this point
Copy the full SHA 90638b4View commit details
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eaac0fb - Browse repository at this point
Copy the full SHA eaac0fbView commit details
Commits on Nov 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 259a4d5 - Browse repository at this point
Copy the full SHA 259a4d5View commit details
Commits on Nov 21, 2023
-
Increase test coverage for AST serialization to >94%. (#11230)
**What this PR does / why we need it**: This is a follow up to #11123 and fixes a few bugs discovered by increasing the test coverage. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a)
Configuration menu - View commit details
-
Copy full SHA for 0db5a7a - Browse repository at this point
Copy the full SHA 0db5a7aView commit details -
[bloom-compactor] Move meta.json creation at the end of compaction cy…
Configuration menu - View commit details
-
Copy full SHA for 5c5983f - Browse repository at this point
Copy the full SHA 5c5983fView commit details -
[bloom-compactor] Add configs to enable compactor per tenant (#11235)
**What this PR does / why we need it**: We want to control bloom compaction per tenant basis. Adding configs to enable/disable bloom compactor. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a)
Configuration menu - View commit details
-
Copy full SHA for e5a439c - Browse repository at this point
Copy the full SHA e5a439cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c30f339 - Browse repository at this point
Copy the full SHA c30f339View commit details -
Update nix configuration (#8452)
Fix nix configuration (mainly failing test), and break up various binaries (ie. logcli, promtail, loki, etc.) into their own pakcages. --------- Co-authored-by: Trevor Whitney <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7666c0d - Browse repository at this point
Copy the full SHA 7666c0dView commit details -
Do not run snyk pr comment workflow on forks (#11240)
Only run the snyk pr comment workflow on PRs from branches, not on forks. We can't run this `on: pull_request_target` because in needs access to the `SNYK_TOKEN` secret, and when run `on: pull_request`, forks don't have permissions to comment on the PR (because they don't get the `GITHUB_TOKEN` secret.
Configuration menu - View commit details
-
Copy full SHA for 8a8d153 - Browse repository at this point
Copy the full SHA 8a8d153View commit details -
Fix per-pod panel unit (from 'ms' to 's') (#11245)
**What this PR does / why we need it**: Change per-pod latency panel unit from 'ms' to 's' (the metric is in the 's' unit)
Configuration menu - View commit details
-
Copy full SHA for da80818 - Browse repository at this point
Copy the full SHA da80818View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51f90eb - Browse repository at this point
Copy the full SHA 51f90ebView commit details -
ksonnet: generate tsdb_shipper storage_config even if using_boltdb_sh…
…ipper is false (#11195) **What this PR does / why we need it**: When configuring tsdb shipper without using bolt db shipper, the ksonnet library fails to generate the tsdb_shipper storage config.
Configuration menu - View commit details
-
Copy full SHA for 9292780 - Browse repository at this point
Copy the full SHA 9292780View commit details -
iterable tokenizer w/ comparison benching (#11255)
Rebuilds tokenizers based on an iterable approach. This ends up being significantly faster -- benchmarks below. This PR doesn't remove the old tokenizers, just adds the new ones. Revamping tokenizer consumers & removing the old variants can be done in a separate PR. Roughly, raw tokenizers complete in 66% of the time and chunkID prefixed tokenizers in ~55-60% of the time. ``` pkg: github.com/grafana/loki/pkg/storage/bloom/v1 BenchmarkTokens/three/v1-10 134811 8648 ns/op 0 B/op 0 allocs/op BenchmarkTokens/three/v2-10 179797 5728 ns/op 0 B/op 0 allocs/op BenchmarkTokens/threeSkip1/v1-10 215822 5260 ns/op 0 B/op 0 allocs/op BenchmarkTokens/threeSkip1/v2-10 343784 3514 ns/op 0 B/op 0 allocs/op BenchmarkTokens/threeChunk/v1-10 82394 14559 ns/op 0 B/op 0 allocs/op BenchmarkTokens/threeChunk/v2-10 146973 8138 ns/op 128 B/op 1 allocs/op BenchmarkTokens/threeSkip1Chunk/v1-10 152475 7878 ns/op 0 B/op 0 allocs/op BenchmarkTokens/threeSkip1Chunk/v2-10 251373 4776 ns/op 128 B/op 1 allocs/op PASS ok github.com/grafana/loki/pkg/storage/bloom/v1 10.206s ```
Configuration menu - View commit details
-
Copy full SHA for b6f6ae7 - Browse repository at this point
Copy the full SHA b6f6ae7View commit details -
inverts the logic when testing a block against a list of chunks (#11248)
returns the list of chunks in the bloom which failed the test so we can merge these results across blocks
Configuration menu - View commit details
-
Copy full SHA for b209492 - Browse repository at this point
Copy the full SHA b209492View commit details -
boundscheck & partitioning fingerprints between blocks (#11237)
Adds a few utilities for comparing fingerprints to blocks that cover a specific fingerprint range. Will likely need to be refactored with more comprehensive types, but the logic still applies.
Configuration menu - View commit details
-
Copy full SHA for ea08e30 - Browse repository at this point
Copy the full SHA ea08e30View commit details -
compactor: do not block compation when retention is taking too long (#…
…9884) **What this PR does / why we need it**: Currently, we perform compaction and apply retention in the same loop. Although we have a flag for not applying retention every time we perform compaction, we still see compaction getting blocked when processing some intensive delete requests(processed while applying retention). This PR separates out the compaction and retention to run in a separate loop. I have added a table-locking feature to avoid compaction and retention from processing the same tables at a time. However, compaction and retention would treat locked tables differently, as explained below: * When compaction sees a table is locked: It would skip the table and move on to the following table. However, before skipping, it would check if the table has any uncompacted files and increment the newly added counter called `loki_compactor_skipped_compacting_locked_tables_total` to track how often we are skipping compacting tables which have uncompacted files. * When retention sees a table is locked: It would wait for the lock to be released since we can't skip any tables while processing delete requests. **Special notes for your reviewer**: * The check for tables with uncompacted files looks for count > 1 because initially, we did not support per tenant index in `boltdb-shipper`, so a table can have a single compacted multi-tenant index file. In a rare case where we have a single file which was supposed to be compacted away, it is okay to have a single uncompacted file for a while. The aim here is to not block compaction for too long in a large cell with too many uncompacted files. * Retention only works on the compacted index, so we first compact down any uncompacted files while applying retention. **Checklist** - [x] Tests updated --------- Co-authored-by: Ashwanth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9e179f2 - Browse repository at this point
Copy the full SHA 9e179f2View commit details -
inflight-logging: Add extra metadata to inflight requests logging (#1…
…1243) **What this PR does / why we need it**: logging: Add extra metadata to inflight requests This adds extra metadata (similar to what we have in `metrics.go`) but for queries in in-flight (both started and retrying) Changes: Adds following data 1. Query Hash 2. Start and End time 3. Start and End delta 4. Length of the query 5. Moved the helper util to `queryutil` package because of cyclic dependencies with `logql` package. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: Find the screenshots of log entries looks like (both in `retry.go` and `roundtrip.go`) ![Screenshot 2023-11-16 at 13 01 32](https://github.com/grafana/loki/assets/3735252/177e97ed-6ee8-41dd-b088-2e4f49562ba0) ![Screenshot 2023-11-16 at 13 02 15](https://github.com/grafana/loki/assets/3735252/fb328a37-dbe3-483e-b083-f21327858029) **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) --------- Signed-off-by: Kaviraj <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3b70dba - Browse repository at this point
Copy the full SHA 3b70dbaView commit details -
operator: Adds new value v13 to schema (#10932)
Co-authored-by: Periklis Tsirakidis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8d2cb04 - Browse repository at this point
Copy the full SHA 8d2cb04View commit details -
operator: Remove outdated BoltDB dashboards (#11022)
Co-authored-by: Periklis Tsirakidis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dab7099 - Browse repository at this point
Copy the full SHA dab7099View commit details -
compaction: Separate metrics for tracking retention and compaction (#…
…11263) **What this PR does / why we need it**: In PR #9884, we separated the retention loop from compaction to avoid blocking compaction for too long due to some intensive delete requests. Currently, we track retention and compaction using the same metrics. This PR adds separate metrics for monitoring retention operation. I have also updated the Retention dashboard to use the new metrics.
Configuration menu - View commit details
-
Copy full SHA for 12106e2 - Browse repository at this point
Copy the full SHA 12106e2View commit details -
Propagate trace ID with HTTP gRPC request. (#11251)
The changes in #10688 did not propage the trace ID from the context. `Frontend.RoundTripGRPC` would inject the trace ID into the request. That's not done in `Frontend.Do`. This changes extends the `codec.EncodeRequest` to inject the trace ID there. This is more inline with other metadata.
Configuration menu - View commit details
-
Copy full SHA for 7ef65b5 - Browse repository at this point
Copy the full SHA 7ef65b5View commit details -
**What this PR does / why we need it**: Removes all usage of v1 tokenizers, renames v2 to v1 since we never released this in a production way. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a)
Configuration menu - View commit details
-
Copy full SHA for 0c94702 - Browse repository at this point
Copy the full SHA 0c94702View commit details -
Fixed the grammatical mistake in an _index.md file (#11226)
**What this PR does / why we need it**: In this PR, I fixed the grammatical mistake in an _index.md file. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) Signed-off-by: Bilal Khan <[email protected]> Co-authored-by: J Stickler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b08319e - Browse repository at this point
Copy the full SHA b08319eView commit details -
Fix Typo in the _index.md (#11242)
**What this PR does / why we need it**: Fixing the small typo in the provided example [here](https://grafana.com/docs/loki/latest/setup/install/helm/configure-storage/#configure-storage). This PR just updates the doc. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) Co-authored-by: Michel Hollands <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c65803 - Browse repository at this point
Copy the full SHA 8c65803View commit details -
use nanosecond precision for timestamp in compacted boltdb-shipper in…
…dex file names (#11277) **What this PR does / why we need it**: In PR #9884, we split the compaction and retention loop to run them concurrently. Although we make sure we do not work on the same index from compaction and retention loop, there is a chance that one could run immediately after the other and finish quickly enough to build the index with the same name as the previous one because in `boltdb-shipper` index, we use epoch with `Seconds` precision while building the name of the compacted index file. Since compaction uploads the new file first and then deletes the old file, if the index is built with the same name, we end up uploading the file and deleting it afterwards. This PR fixes the issue by using ns precision for the timestamp in the filenames. **Special notes for your reviewer**: This is not a problem for TSDB since we also add a checksum to the filenames of the index during compaction.
Configuration menu - View commit details
-
Copy full SHA for eb8ad93 - Browse repository at this point
Copy the full SHA eb8ad93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31fc35b - Browse repository at this point
Copy the full SHA 31fc35bView commit details