-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSSQL Integration - Update documentation with extra windows authentication details #6325
MSSQL Integration - Update documentation with extra windows authentication details #6325
Conversation
Requested by WF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
docs/sources/flow/reference/components/prometheus.exporter.mssql.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/prometheus.exporter.mssql.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/prometheus.exporter.mssql.md
Outdated
Show resolved
Hide resolved
b0af3a9
to
fe2fdb6
Compare
@clayton-cornell Implemented your feedback (with a few tweaks). Ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ae4b178
to
1702b5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@StefanKurek This looks safe to backport to v0.39, 0.38, and 0.37... correct? |
@clayton-cornell Yeah, this shouldn't be an issue. |
36218ad
to
7f0444b
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6325-to-release-v0.37 origin/release-v0.37
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 86e6378145461d79a554d08327b64e0fca57629f
# Push it to GitHub
git push --set-upstream origin backport-6325-to-release-v0.37
git switch main
# Remove the local backport branch
git branch -D backport-6325-to-release-v0.37 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6325-to-release-v0.38 origin/release-v0.38
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 86e6378145461d79a554d08327b64e0fca57629f
# Push it to GitHub
git push --set-upstream origin backport-6325-to-release-v0.38
git switch main
# Remove the local backport branch
git branch -D backport-6325-to-release-v0.38 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6325-to-release-v0.39 origin/release-v0.39
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 86e6378145461d79a554d08327b64e0fca57629f
# Push it to GitHub
git push --set-upstream origin backport-6325-to-release-v0.39
git switch main
# Remove the local backport branch
git branch -D backport-6325-to-release-v0.39 Then, create a pull request where the |
Cancelled backport to v0.38 and v0.37. There are too many differences in this section between 0.39 and previous versions. |
…ation details (grafana#6325) * Updates MSSQL Integrations docs with extra auth details * Tweaks wording of MSSQL integration auth section in docs
PR Description
Updates MSSQL Integration documentation to explicitly mention some of the windows authentication options that can be used within the
connection_string
config param for both static and flow modes.Which issue(s) this PR fixes
NA
Notes to the Reviewer
PR Checklist