cmake: Remove remaining checks for CMAKE_VERSION #4293
Conversation
Remove conditional code that doesn't need to exist anymore.
| if (CMAKE_VERSION VERSION_LESS "2.8.12") | ||
| add_compile_options("-Wa,-mbig-obj") | ||
| else() | ||
| add_definitions("-Wa,-mbig-obj") |
There was a problem hiding this comment.
add_definitions is used to add defines to the code like NOMINMAX or WIN32_LEAN_AND_MEAN using it for compiler options isn't correct.
Also add_definitions isn't recommended for usage anymore:
https://cmake.org/cmake/help/latest/command/add_definitions.html#command:add_definitions
| return() | ||
| endif() | ||
|
|
||
| get_cmake_property(is_multi "GENERATOR_IS_MULTI_CONFIG") |
There was a problem hiding this comment.
Note GENERATOR_IS_MULTI_CONFIG was added in 3.9 and should be used here instead of CMAKE_CONFIGURATION_TYPES.
https://cmake.org/cmake/help/latest/prop_gbl/GENERATOR_IS_MULTI_CONFIG.html
|
There are now no more instances of |
|
Thanks for the cleanup! Just for posterity, explicitly running python3 in cmake is based on the fact that googletest's python tests are actually written in python3 (as of a few years ago). |
Remove conditional code that doesn't need to exist anymore.