cmake: Update googletest / glslang to fix CMake warnings #6073
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 1068. |
|
CI Vulkan-ValidationLayers build # 12536 running. |
|
CI Vulkan-ValidationLayers build # 12536 passed. |
| @@ -75,7 +75,7 @@ | |||
| "-Dgtest_force_shared_crt=ON", | |||
| "-DBUILD_SHARED_LIBS=OFF" | |||
| ], | |||
| "commit": "v1.13.0", | |||
| "commit": "ec4fed93217bc2830959bb8e86798c1d86956949", | |||
There was a problem hiding this comment.
We used tagged release previously, do they continue to create new releases? I heard they use live at the HEAD internally, so I guess it should be fine.
There was a problem hiding this comment.
Google test very infrequently creates tagged releases. The have a live at head philosophy so it's fine to use specific commits.
GoogleTest now follows the Abseil Live at Head philosophy. We recommend updating to the latest commit in the main branch as often as possible. We do publish occasional semantic versions, tagged with v${major}.${minor}.${patch} (e.g. v1.13.0).
Relevant PRs I made to fix these warnings in these repos:
KhronosGroup/glslang#3241
google/googletest#4288
google/googletest#4290
google/googletest#4293