Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change profiling based partitoner's last_segment_latency to slowest_segment_latency #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change profiling based partitoner's last_segment_latency to slowest_segment_latency #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions coral/tools/partitioner/profiling_based_partitioner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ bool ProfilingBasedPartitioner::SearchPartition(
int64_t ProfilingBasedPartitioner::PartitionOnTargetLatency(
int64_t target_latency, int partition_search_step,
int delegate_search_step) {
int64_t segment_latency;
CHECK_GT(partition_search_step, 0);
// Initially, the first segment takes most operators and each other segment
// takes one operator.
Expand All @@ -308,14 +309,20 @@ int64_t ProfilingBasedPartitioner::PartitionOnTargetLatency(
}

CHECK_EQ(std::accumulate(num_ops.begin(), num_ops.end(), 0), total_num_ops);
const auto last_segment_latency = PartitionCompileAndAnalyze(
num_ops, num_segments_ - 1, delegate_search_step);

int64_t slowest_segment_latency = 0;
for (int i = 0; i < num_segments_; i++) {
segment_latency = PartitionCompileAndAnalyze(partition_, i);
if (segment_latency >= slowest_segment_latency)
slowest_segment_latency = segment_latency;
}

CHECK_GT(last_segment_latency, 0);
LOG(INFO) << "target_latency: " << target_latency
<< ", num_ops: " << absl::StrJoin(num_ops, ",")
<< ", last segment latency: " << last_segment_latency;
partition_ = num_ops;
return last_segment_latency;
return slowest_segment_latency;
}

bool BisectPartition(const std::string& edgetpu_compiler_binary,
Expand Down Expand Up @@ -345,21 +352,23 @@ bool BisectPartition(const std::string& edgetpu_compiler_binary,

while (std::abs(upper_bound - lower_bound) > diff_threshold_ns) {
const int64_t target_latency = (lower_bound + upper_bound) / 2;
const int64_t last_segment_latency = partitioner.PartitionOnTargetLatency(
target_latency, partition_search_step, delegate_search_step);
const int64_t slowest_segment_latency =
partitioner.PartitionOnTargetLatency(
target_latency, partition_search_step, delegate_search_step);

// If latency of the last segment is lower than `target_latency`, it
// means that `target_latency` gives a valid partition.
if (last_segment_latency < target_latency) {
if (slowest_segment_latency < target_latency) {
best_partition = partitioner.partition();
CHECK(!best_partition.empty());
upper_bound = target_latency;
} else {
// If latency of the last segment is higher than `target_latency` but
// lower than `upper_bound`, `upper_bound` could be updated as well.
if (last_segment_latency < upper_bound) {
if (slowest_segment_latency < upper_bound) {
best_partition = partitioner.partition();
CHECK(!best_partition.empty());
upper_bound = last_segment_latency;
upper_bound = slowest_segment_latency;
}
lower_bound = target_latency;
}
Expand Down