Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change profiling based partitoner's last_segment_latency to slowest_segment_latency #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HanChangHun
Copy link

Changed profile-based partitioner's last_segment_latency to slowest_segment_latency.

Actually it does not guarantee gap between slowest_segment_latency and fastest_segment_latency lower than diff_threshold_ns. But when using this code, I can see that the difference was reduced.

I tried to use a different method, but I didn't converge.

And I tested by utilizing only one TPU. So I couldn't proceed with the experiment on more than 2 TPUs.
I'm using M.2 Accelerator with Dual Edge TPU, but I can't catch two TPUs... So my test can be inaccurate.

@google-cla
Copy link

google-cla bot commented Jun 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant