Bids 2006/validator rank via api

src/app/components/dashboard/dashboard.component.html

@@ -724,7 +724,7 @@
 		<ion-label>General</ion-label>
 	</ion-list-header>
 
-	<ion-list class="performance">
+	<ion-list class="performance" *ngIf="data.bestRank != 0">
 		<ion-item lines="none" *ngIf="data.bestRank == data.worstRank">
 			<ion-label class="stat-title">
 				<span tooltip="Global rank of this validator, based on last 7 days" placement="right" trigger="click" hideDelayAfterClick="5000"> Rank </span>
@@ -734,7 +734,7 @@
 				<ion-icon name="ribbon-outline" class="rank-ribbon"></ion-icon>
 
 				<span class="rank-text">
-					{{ data.bestRank | percentageabs : data.currentEpoch.validatorscount : rankPercentMode : 'Top ' }}
+					{{ data.bestRank | percentageabs : data.bestTopPercentage : rankPercentMode : 'Top ' }}
 				</span>
 			</ion-label>
 		</ion-item>
@@ -746,7 +746,7 @@
 						<ion-label class="value left">
 							<ion-icon name="ribbon-outline" class="rank-ribbon"></ion-icon>
 							<span class="rank-text">
-								{{ data.bestRank | percentageabs : data.currentEpoch.validatorscount : rankPercentMode : 'Top ' }}
+								{{ data.bestRank | percentageabs : data.bestTopPercentage : rankPercentMode : 'Top ' }}
 							</span>
 						</ion-label>
 					</div>
@@ -768,7 +768,7 @@
 						<ion-label class="value">
 							<ion-icon name="ribbon-outline" class="rank-ribbon"></ion-icon>
 							<span class="rank-text">
-								{{ data.worstRank | percentageabs : data.currentEpoch.validatorscount : rankPercentMode : 'Top ' }}
+								{{ data.worstRank | percentageabs : data.worstTopPercentage : rankPercentMode : 'Top ' }}
 							</span>
 						</ion-label>
 					</div>

src/app/controllers/OverviewController.ts

@@ -39,6 +39,8 @@ export type OverviewData = {
 	activationeligibilityCount: number
 	bestRank: number
 	worstRank: number
+	bestTopPercentage: number
+	worstTopPercentage: number
 	displayAttrEffectiveness: boolean
 	attrEffectiveness: number
 
@@ -157,6 +159,7 @@ export default class OverviewController {
 		const overallBalance = this.sumBigIntBalanceRP(validators, (cur) => new BigNumber(cur.data.balance))
 		const validatorCount = validators.length
 		const activeValidators = this.getActiveValidators(validators)
+		const offlineValidators = this.getOfflineValidators(validators)
 
 		const consensusPerf = this.getConsensusPerformance(validators, validatorDepositActive)
 
@@ -190,8 +193,18 @@ export default class OverviewController {
 			}
 		}
 
-		const bestRank = findLowest(validators, (cur) => cur.data.rank7d)
-		const worstRank = findHighest(validators, (cur) => cur.data.rank7d)
+		let bestRank = 0
+		let bestTopPercentage = 0
+		let worstRank = 0
+		let worstTopPercentage = 0
+		const rankRelevantValidators = activeValidators.concat(offlineValidators)
+		if (rankRelevantValidators.length > 0) {
+			bestRank = findLowest(rankRelevantValidators, (cur) => cur.data.rank7d)
+			bestTopPercentage = findLowest(rankRelevantValidators, (cur) => cur.data.rankpercentage)
+			worstRank = findHighest(rankRelevantValidators, (cur) => cur.data.rank7d)
+			worstTopPercentage = findHighest(rankRelevantValidators, (cur) => cur.data.rankpercentage)
+		}
+
 		const rocketpoolValiCount = sumBigInt(validators, (cur) => (cur.rocketpool ? new BigNumber(1) : new BigNumber(0)))
 		const feeSum = sumBigInt(validators, (cur) =>
 			cur.rocketpool ? new BigNumber(cur.rocketpool.minipool_node_fee).multipliedBy('100') : new BigNumber('0')
@@ -213,7 +226,9 @@ export default class OverviewController {
 			overallBalance: overallBalance,
 			validatorCount: validatorCount,
 			bestRank: bestRank,
+			bestTopPercentage: bestTopPercentage,
 			worstRank: worstRank,
+			worstTopPercentage: worstTopPercentage,
 			attrEffectiveness: attrEffectiveness,
 			displayAttrEffectiveness: displayAttrEffectiveness,
 			consensusPerformance: consensusPerf,
@@ -810,6 +825,12 @@ export default class OverviewController {
 		})
 	}
 
+	private getOfflineValidators(validators: Validator[]) {
+		return validators.filter((item) => {
+			return item.state == ValidatorState.OFFLINE
+		})
+	}
+
 	private getSlashedValidators(validators: Validator[]) {
 		return validators.filter((item) => {
 			return item.state == ValidatorState.SLASHED

src/app/pipes/percentageabs.pipe.ts

@@ -25,17 +25,31 @@ import BigNumber from 'bignumber.js'
 	name: 'percentageabs',
 })
 export class PercentageabsPipe implements PipeTransform {
-	transform(value_: number | BigNumber, max_: number | BigNumber, percentMode: boolean, preablePrct = ''): string {
-		const value = value_ instanceof BigNumber ? value_ : new BigNumber(value_)
-		const max = max_ instanceof BigNumber ? max_ : new BigNumber(max_)
-
+	/**
+	 * Takes an absolute value (`value_`) and a relative percentage representation of it (`percentage_`  ) and returns a formatted string of one of those (based on `percentMode`).
+	 *
+	 * @param {number | BigNumber} value_ - The absolute value to be shown (used when `percentMode` is false).
+	 * @param {number | BigNumber} percentage_ - The relative percentage representation for the value (used when `percentMode` is true)
+	 * @param {boolean} percentMode - A flag indicating whether to use `value_` (false) or `percentage_` (true).
+	 * @param {string} [prefix=''] - An optional prefix to prepend to the resulting string if the absolute value is shown.
+	 * @returns {string} The formatted string.
+	 */
+	transform(value_: number | BigNumber, percentage_: number | BigNumber, percentMode: boolean, prefix = ''): string {
 		if (percentMode) {
-			let percentValue = value.dividedBy(max).multipliedBy(100).decimalPlaces(1)
-			if (percentValue.toNumber() <= 0.1) {
-				percentValue = value.dividedBy(max).multipliedBy(100).decimalPlaces(3)
+			const percentage = percentage_ instanceof BigNumber ? percentage_ : new BigNumber(percentage_)
+			const percentageNumber = percentage.toNumber()
+			if (percentageNumber <= 0.1) {
+				return prefix + '0.1 %'
+			}
+			let decimalPlaces = 1
+			if (percentageNumber < 1.0) {
+				decimalPlaces = 3
+			} else if (percentageNumber < 10.0) {
+				decimalPlaces = 2
 			}
-			return preablePrct + percentValue.toString() + ' %'
+			return prefix + percentage.decimalPlaces(decimalPlaces).toString() + ' %'
 		} else {
+			const value = value_ instanceof BigNumber ? value_ : new BigNumber(value_)
 			return value.toFormat()
 		}
 	}

src/app/requests/requests.ts

@@ -182,8 +182,9 @@ export interface ValidatorResponse {
 	performance31d: BigNumber
 	performance365d: BigNumber
 	performance7d: BigNumber
-	rank7d: number
 	performancetotal: BigNumber
+	rank7d: number
+	rankpercentage: number
 }
 
 export interface AttestationPerformanceResponse {