Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids 2006/validator rank via api #235

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Bids 2006/validator rank via api #235

merged 5 commits into from
Sep 13, 2023

Conversation

D13ce
Copy link
Collaborator

@D13ce D13ce commented Aug 29, 2023

With this PR, the app now uses the validators' "Top X%" rank served by the dashboard API endpoint via gobitfly/eth2-beaconchain-explorer#2511.
Furthermore, the handling has been unified with the explorer: Only ranks for active validators now are shown.

Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR's alright, there's however exceptionally tiny inconsistencies causing concerns

src/app/pipes/percentageabs.pipe.ts Show resolved Hide resolved
src/app/pipes/percentageabs.pipe.ts Outdated Show resolved Hide resolved
src/app/pipes/percentageabs.pipe.ts Outdated Show resolved Hide resolved
src/app/controllers/OverviewController.ts Outdated Show resolved Hide resolved
- Add documentation to PercentageabsPipe
- Refactor PercentageabsPipe
- Rename variables
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luccs good to me

@D13ce D13ce merged commit 7fdd1bb into main Sep 13, 2023
2 checks passed
@D13ce D13ce deleted the BIDS-2006/ValidatorRankViaAPI branch September 13, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants