Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user): basculer l'authentification vers ProConnect #731

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat(user): basculer l'authentification vers ProConnect #731

wants to merge 9 commits into from

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Jul 31, 2024 •
edited
Loading

Description

🎸 Inclusion Connect est remplacé par Pro Connect (https://moncomptepro.beta.gouv.fr/) en tant que fournisseur d'identité
🎸 La migration des comptes est réalisée au fil de l'eau, lors de chaque première connection d'un utilisateur précédemment inscrit via Inclusion Connect.

Type de changement

🚧 technique

Points d'attention

🦺 renommage de l'app django
🦺 mise à jour des urls
🦺 ajout du paramètre "acr_values": "eidas1" lors de l'appel au end-point authorize
🦺 remplacement de family_name par usual_name lors de l'appel au end-point user-info
🦺 decoder user_data à l'aide de la lib PyJWT

@vincentporte vincentporte linked an issue Jul 31, 2024 that may be closed by this pull request
[USER] bascule IC > ProC #729
Open
7 tasks
@vincentporte vincentporte added the python Pull requests that update Python code label Jul 31, 2024
@vincentporte vincentporte force-pushed the 729-user-bascule-ic-proc branch 3 times, most recently from e8f1f04 to f71c504 Compare July 31, 2024 14:13
@vincentporte vincentporte requested a review from tonial July 31, 2024 14:16
tonial
tonial reviewed Aug 5, 2024
View reviewed changes
Copy link

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que tu n'as pas mis à jour le template du bouton de connexion.

Sinon, ça m'a l'air bien (il faudrait peut être faire une recherche d'inclusion.*connect dans le repo de code pour vérifier qu'il n'en reste pas quelque part comme le commentaire repéré.

Est-ce que tu as moyen de désactiver temporairement la connexion (le temps de mettre à jour les subs le jour J) ?

.env.template Outdated Show resolved Hide resolved
lacommunaute/openid_connect/models.py Show resolved Hide resolved
@vincentporte vincentporte added the recette-jetable review_app label Aug 27, 2024
@vincentporte vincentporte marked this pull request as ready for review August 27, 2024 12:04
@vincentporte vincentporte added recette-jetable review_app and removed recette-jetable review_app labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@vincentporte vincentporte removed the recette-jetable review_app label Aug 28, 2024
@vincentporte
Copy link
Contributor Author

vincentporte commented Aug 28, 2024 •
edited
Loading

  • ajout des variables d'environnement OPENID_CONNECT_BASE_URL , OPENID_CONNECT_CLIENT_ID et OPENID_CONNECT_CLIENT_SECRET
  • installation du sous-domaine staging.communaute.inclusion.beta.gouv.fr

Echec en code erreur Y000404

@vincentporte vincentporte added the recette-jetable review_app label Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@vincentporte
Copy link
Contributor Author

@vincentporte
Copy link
Contributor Author

vincentporte commented Aug 29, 2024 •
edited
Loading

@vincentporte vincentporte force-pushed the 729-user-bascule-ic-proc branch 5 times, most recently from 8da1b8f to 985ebfe Compare August 29, 2024 13:02
@vincentporte vincentporte removed the recette-jetable review_app label Aug 29, 2024
tonial
tonial approved these changes Sep 2, 2024
View reviewed changes
.env.template Outdated Show resolved Hide resolved
config/urls.py Outdated Show resolved Hide resolved
config/urls.py Outdated Show resolved Hide resolved
This was referenced Sep 24, 2024
Closed
Merged
vincentporte added a commit that referenced this pull request Sep 25, 2024
@vincentporte
feat: page parking (#788)
732bd5c 
## Description

🎸 Ajout d'un `middleware` pour activer une page parking lors des
maintenances techniques à venir : migration IC #731 , et migration de la
documentation #765

## Type de changement

🚧 technique

### Points d'attention

🦺 Ajout de la variable d'environnement `PARKING_PAGE`
🦺 `ParkingPageMiddleware` attrape toutes les requêtes sauf celles vers
l'admin lorsqu'il est actif.
🦺 exclure le template `parking.html` du contrôle de `djlint` dans la CI
(`make quality`)


### Captures d'écran (optionnel)

page parking


![image](https://github.com/user-attachments/assets/7ad1960e-171e-4d46-b177-11c2084dea9f)
vincentporte added a commit that referenced this pull request Sep 25, 2024
@vincentporte
feat: page parking (#788)
9690f9a 
## Description

🎸 Ajout d'un `middleware` pour activer une page parking lors des
maintenances techniques à venir : migration IC #731 , et migration de la
documentation #765

## Type de changement

🚧 technique

### Points d'attention

🦺 Ajout de la variable d'environnement `PARKING_PAGE`
🦺 `ParkingPageMiddleware` attrape toutes les requêtes sauf celles vers
l'admin lorsqu'il est actif.
🦺 exclure le template `parking.html` du contrôle de `djlint` dans la CI
(`make quality`)


### Captures d'écran (optionnel)

page parking


![image](https://github.com/user-attachments/assets/7ad1960e-171e-4d46-b177-11c2084dea9f)
@vincentporte vincentporte marked this pull request as draft October 7, 2024 15:03
@tonial tonial changed the title feat(user): basculer l'authentification vers Mon Compte Pro feat(user): basculer l'authentification vers ProConnect Nov 4, 2024
@vincentporte vincentporte changed the title feat(user): basculer l'authentification vers ProConnect feat(user): basculer l'authentification vers ProConnect (1/3) Nov 4, 2024
@vincentporte vincentporte changed the title feat(user): basculer l'authentification vers ProConnect (1/3) feat(user): basculer l'authentification vers ProConnect Nov 4, 2024
@vincentporte vincentporte marked this pull request as ready for review November 4, 2024 15:09
tonial
tonial approved these changes Nov 4, 2024
View reviewed changes
lacommunaute/openid_connect/models.py Show resolved Hide resolved
lacommunaute/openid_connect/tests/tests_model.py Outdated Show resolved Hide resolved
@vincentporte vincentporte mentioned this pull request Nov 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonial tonial tonial approved these changes

Assignees

@vincentporte vincentporte

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[USER] bascule IC > ProC
2 participants
@vincentporte @tonial