Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: page parking #788

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat: page parking #788

merged 2 commits into from
Sep 25, 2024

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Sep 24, 2024

Description

🎸 Ajout d'un middleware pour activer une page parking lors des maintenances techniques à venir : migration IC #731 , et migration de la documentation #765

Type de changement

🚧 technique

Points d'attention

🦺 Ajout de la variable d'environnement PARKING_PAGE
🦺 ParkingPageMiddleware attrape toutes les requêtes sauf celles vers l'admin lorsqu'il est actif.
🦺 exclure le template parking.html du contrôle de djlint dans la CI (make quality)

Captures d'écran (optionnel)

page parking

image

@vincentporte vincentporte linked an issue Sep 24, 2024 that may be closed by this pull request
@vincentporte vincentporte added the python Pull requests that update Python code label Sep 24, 2024
@tonial
Copy link

tonial commented Sep 25, 2024

J'ai eu un doute sur le login, mais le login via l'admin est bien dans une url qui commence par /admin/ 👍

@vincentporte vincentporte merged commit 732bd5c into master Sep 25, 2024
11 checks passed
@vincentporte vincentporte deleted the 787-tech-page-parking branch September 25, 2024 07:14
@@ -22,6 +22,9 @@ INCLUSION_CONNECT_BASE_URL=http://127.0.0.1:8080
INCLUSION_CONNECT_CLIENT_ID=local_inclusion_connect
INCLUSION_CONNECT_CLIENT_SECRET=password

# parking page
PARKING_PAGE=True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je suppose que par défaut on ne veux pas la page parking donc je dirais plutôt :

Suggested change
PARKING_PAGE=True
PARKING_PAGE=False

vincentporte added a commit that referenced this pull request Sep 25, 2024
## Description

🎸 Ajout d'un `middleware` pour activer une page parking lors des
maintenances techniques à venir : migration IC #731 , et migration de la
documentation #765

## Type de changement

🚧 technique

### Points d'attention

🦺 Ajout de la variable d'environnement `PARKING_PAGE`
🦺 `ParkingPageMiddleware` attrape toutes les requêtes sauf celles vers
l'admin lorsqu'il est actif.
🦺 exclure le template `parking.html` du contrôle de `djlint` dans la CI
(`make quality`)


### Captures d'écran (optionnel)

page parking


![image](https://github.com/user-attachments/assets/7ad1960e-171e-4d46-b177-11c2084dea9f)
vincentporte pushed a commit that referenced this pull request Oct 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.15.0](v2.14.0...v2.15.0)
(2024-10-07)


### Features

* ajout d'un sondage pour mieux connaitre les utilisateurs de la
communauté
([#781](#781))
([171bdde](171bdde))
* page parking
([#788](#788))
([732bd5c](732bd5c))
* **partner:** ajout des pages de creation / mise à jour depuis la page
"nos partenaires"
([#780](#780))
([4001074](4001074))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECH] page parking
3 participants