-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag tracking #3503
Draft
cmanallen
wants to merge
3
commits into
master
Choose a base branch
from
cmanallen/flags-initial
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
from typing import TYPE_CHECKING | ||
from sentry_sdk._lru_cache import LRUCache, KEY, NEXT, VALUE | ||
|
||
|
||
if TYPE_CHECKING: | ||
from sentry_sdk._types import Flag as FType, Flags | ||
|
||
|
||
class Flag: | ||
|
||
__slots__ = ("name", "result") | ||
|
||
def __init__(self, name, result): | ||
# type: (str, bool) -> None | ||
self.result = result | ||
self.name = name | ||
|
||
@property | ||
def as_dict(self): | ||
# type: () -> FType | ||
return { | ||
"flag": self.name, | ||
"result": self.result, | ||
} | ||
|
||
|
||
class FlagManager: | ||
|
||
def __init__(self, capacity): | ||
# type: (int) -> None | ||
self._cache = LRUCache(max_size=capacity) | ||
|
||
def add(self, name, result): | ||
# type: (str, bool) -> None | ||
# NOTE: Should we log null names? | ||
if name is not None: | ||
self._cache.set(name, Flag(name, result)) | ||
|
||
def serialize(self): | ||
# type: () -> Flags | ||
"""Serialize flags. | ||
|
||
Flags are serialized in order of first-evaluation. | ||
""" | ||
|
||
def iter_flags(): | ||
# This only works if you know the root node is the only | ||
# item with a null key. The list is circularly linked so we | ||
# need a termination condition. | ||
node = self._cache.root[NEXT] | ||
while node[KEY] is not None: | ||
yield node[VALUE].as_dict | ||
node = node[NEXT] | ||
|
||
return [f for f in iter_flags()] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
from sentry_sdk.flag import Flag, FlagManager | ||
|
||
|
||
def test_serializing_flag(): | ||
flag = Flag("k", True) | ||
assert flag.as_dict == {"flag": "k", "result": True} | ||
|
||
|
||
def test_flag_manager(): | ||
manager = FlagManager(capacity=2) | ||
|
||
# Partially filled buffer serializes in the correct order. | ||
manager.add("a", True) | ||
flags = manager.serialize() | ||
assert flags == [{"flag": "a", "result": True}] | ||
|
||
# Filled buffer serializes in the correct order. | ||
manager.add("b", False) | ||
flags = manager.serialize() | ||
assert flags == [{"flag": "a", "result": True}, {"flag": "b", "result": False}] | ||
|
||
# Over-filled buffer serializes in the correct order. | ||
manager.add("c", True) | ||
flags = manager.serialize() | ||
assert flags == [{"flag": "b", "result": False}, {"flag": "c", "result": True}] | ||
|
||
# Twice-filled buffer serializes in the correct order. | ||
manager.add("d", True) | ||
flags = manager.serialize() | ||
assert flags == [{"flag": "c", "result": True}, {"flag": "d", "result": True}] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antonpirker Could you help me fill in the gaps here? Where should this live? Also are scopes nested? Would it be possible to merge the flags from a global scope and a thread scope here?