Add feature flag tracking #3503
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 7422 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
cmanallen
commented
Sep 10, 2024
| @@ -482,6 +482,9 @@ def _prepare_event( | |||
| "event_processor", data_category="span", quantity=spans_delta | |||
| ) | |||
|
|
|||
| # TODO: Where should I put this? | |||
| event["contexts"]["flags"] = scope._flag_manager.serialize() | |||
There was a problem hiding this comment.
@antonpirker Could you help me fill in the gaps here? Where should this live? Also are scopes nested? Would it be possible to merge the flags from a global scope and a thread scope here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related RFC: getsentry/rfcs#140
TODO:
Related to: