Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add paths configuration to GitHub Actions for charts structure #67

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

electrosenpai
Copy link
Contributor

@electrosenpai electrosenpai commented Sep 23, 2024

Description

This Pull Request introduces an update to the GitHub Actions workflow to align with the current chart structure.

Key Changes:

  • Added path configurations in the CI workflow to ensure correct paths for both the main chart.
  • Updated Helm dependencies using helm dependency update to ensure all charts are up to date.
  • Maintained the automation for chart releases and publishing to GitHub Pages.

Why this change is necessary:

This update is required due to the specific chart structure of the repository. The previous configuration didn't account for the custom path locations of the charts, which could lead to issues during the CI/CD process. By adjusting the paths, we ensure that all charts are correctly linted, packaged, and published.

Checklist:

  • Added path corrections for Helm charts.
  • Verified that helm lint runs successfully for all charts.
  • Tested the release process with the new path configurations.

@electrosenpai electrosenpai marked this pull request as ready for review September 24, 2024 08:40
@electrosenpai
Copy link
Contributor Author

This issue will also close both PRs:

#55
https://github.com/getlago/lago-helm-charts/pull/16/files

Unfortunately, we are unable to implement such significant changes as proposed in these two PRs at this time. Some of our users rely on pulling the Git repository directly to deploy Lago, and we want to avoid introducing breaking changes for now. We truly appreciate your initiatives, gilliangoud and grafjo. 🙏

@electrosenpai electrosenpai merged commit b250373 into main Sep 24, 2024
1 check passed
@electrosenpai electrosenpai mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants