Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor battery demo #633

Draft
wants to merge 3 commits into
base: ros2
Choose a base branch
from
Draft

Refactor battery demo #633

wants to merge 3 commits into from

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 5, 2024

Refactors the battery demo leveraging the latest improvements in ros_gz.

  • I replaced the previous launch file from Python to XML because I think it's the recommendation (and looks easier) but I'll still keep some of the demos in Python to offer some variety.
  • I didn't implement support for running gzserver with -z 1000000.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero changed the title Battery demo refactor Refactor battery demo Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants