Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_own_container argument to ros_gz_spawn_model.launch.py (backport #622) #625

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 25, 2024

🦟 Bug fix

Summary

Adds the create_own_container argument added in #616 to ros_gz_spawn_model.launch.py

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #622 done by Mergify.

@Amronos
Copy link
Contributor

Amronos commented Oct 25, 2024

Should I make a separate PR to fix DCO?

@ahcorde ahcorde merged commit d9c7ff8 into jazzy Oct 28, 2024
6 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-622 branch October 28, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants