Ensure the same container is used for the bridge and gz_server #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a required `name` parameter for the bridge so that multiple different bridges can be created without name collision Signed-off-by: Addisu Z. Taddese <[email protected]>
ahcorde
approved these changes
May 30, 2024
caguero
approved these changes
May 31, 2024
8 tasks
Amronos
pushed a commit
to Amronos/ros_gz
that referenced
this pull request
Sep 18, 2024
…osim#553) This also adds a required `name` parameter for the bridge so that multiple different bridges can be created without name collision Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of #544
Summary
Using
ComposableNodeContainerfor bothgz_serverandros_gz_bridgecaused a new container to be created for each of them. This changes ros_gz_bridge to useLoadComposableNodeswhich uses an existing container, which would be created when launchinggz_server. I've tested that this works even ifros_gz_bridgewas launched first.This also adds a required
nameparameter for the bridge so that multiple different bridges can be created without name collisionChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.