Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change material color from ROS. #521

Merged
merged 2 commits into from
May 6, 2024

Conversation

bperseghetti
Copy link
Member

Forward port of PR #486 from humble to iron

* Message and bridge for MaterialColor.

This allows bridging MaterialColor from ROS to GZ and is
important for allowing simulation users to create status lights.

➡️ Forward port

Single feature forward port from modified cherry-pick

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Forward port of gazebosim#486.

    * Message and bridge for MaterialColor.

    This allows bridging MaterialColor from ROS to GZ and is
    important for allowing simulation users to create status lights.

Signed-off-by: Benjamin Perseghetti <[email protected]>
@azeey
Copy link
Contributor

azeey commented May 6, 2024

@bperseghetti can you merge from ros2 to get updated CI checks?

@azeey azeey self-requested a review May 6, 2024 17:04
@bperseghetti
Copy link
Member Author

@azeey back to you! 🙃

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azeey azeey merged commit 78dc482 into gazebosim:ros2 May 6, 2024
2 checks passed
@bperseghetti bperseghetti deleted the pr-ros2-material_color branch May 6, 2024 18:04
@azeey
Copy link
Contributor

azeey commented Jun 25, 2024

https://github.com/Mergifyio backport jazzy

Copy link
Contributor

mergify bot commented Jun 25, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 25, 2024
Forward port of #486.

    * Message and bridge for MaterialColor.

    This allows bridging MaterialColor from ROS to GZ and is
    important for allowing simulation users to create status lights.

Signed-off-by: Benjamin Perseghetti <[email protected]>
(cherry picked from commit 78dc482)
azeey pushed a commit that referenced this pull request Jun 25, 2024
Forward port of #486.

    * Message and bridge for MaterialColor.

    This allows bridging MaterialColor from ROS to GZ and is
    important for allowing simulation users to create status lights.

Signed-off-by: Benjamin Perseghetti <[email protected]>
(cherry picked from commit 78dc482)
Amronos pushed a commit to Amronos/ros_gz that referenced this pull request Sep 18, 2024
Forward port of gazebosim#486.

    * Message and bridge for MaterialColor.

    This allows bridging MaterialColor from ROS to GZ and is
    important for allowing simulation users to create status lights.

Signed-off-by: Benjamin Perseghetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants