-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Harmonic/Humble pairing #462
Conversation
* Add harmonic CI Signed-off-by: Michael Carroll <[email protected]> * Include garden options Signed-off-by: Michael Carroll <[email protected]> * Add harmonic stanza Signed-off-by: Michael Carroll <[email protected]> * Additional message headers Signed-off-by: Michael Carroll <[email protected]> --------- Signed-off-by: Michael Carroll <[email protected]>
) Harmonic is now in the prerelease repository Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would maybe suggest adding edits to the README.md though for harmonic as it's currently not listing Garden and hopefully soon Harmonic for Humble.
ROS 2 version | Gazebo version | Branch | Binaries hosted at |
---|---|---|---|
Foxy | Citadel | foxy | https://packages.ros.org |
Foxy | Edifice | foxy | only from source |
Galactic | Edifice | galactic | https://packages.ros.org |
Galactic | Fortress | galactic | only from source |
Humble | Fortress | humble | https://packages.ros.org |
Humble | Garden | humble | gazebo packages |
Humble | Harmonic | humble | gazebo packages |
Rolling | Edifice | ros2 | only from source |
Rolling | Fortress | ros2 | https://packages.ros.org |
Rolling | Garden | ros2 | only from source |
I should also mention that's what I think the README.md should look like. Basically adding/editing:
Forgot I don't have approval permissions 🤣 well, there's my mostly non-meaningful review/approval. |
Signed-off-by: Addisu Z. Taddese <[email protected]>
I've updated the readme with two modifications from your suggestion:
|
* Add harmonic CI (gazebosim#447) * Add harmonic CI Signed-off-by: Michael Carroll <[email protected]> * Include garden options Signed-off-by: Michael Carroll <[email protected]> * Add harmonic stanza Signed-off-by: Michael Carroll <[email protected]> * Additional message headers Signed-off-by: Michael Carroll <[email protected]> --------- Signed-off-by: Michael Carroll <[email protected]> * Use stable osrf repo for Garden and stable+prerelease for Harmonic (gazebosim#448) Harmonic is now in the prerelease repository Signed-off-by: Jose Luis Rivero <[email protected]> * Add additional cmake/package.xml changes * Update headers * Update namespaces * Add ci for harmonic/humble * Update readme --------- Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Signed-off-by: Ayush1285 <[email protected]>
Fixes #461
Summary
Cherry-picks #447 and #448, update headers (3853cf2) and namespaces ( 66b61f2) and makes some tweaks to CMake and package.xml so that the
humble
branch can be built with Harmonic as well as Fortress.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.