Add optical frame publisher from subt/mbzirc #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapulina
suggested changes
Jun 13, 2022
caguero
reviewed
Jun 27, 2022
|
This is going to be retargeted to galactic, and I have also made an effort to robustify tests here: #272 |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
optical_image_publisher
branch
from
261e6c0
to
bb32212
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
|
what's the state of this PR @mjcarroll ? |
|
It just fell off my radar, probably just needs one more round of review and it's good to go. |
caguero
reviewed
Aug 23, 2023
ahcorde
requested changes
Jan 4, 2024
There was a problem hiding this comment.
@mjcarroll This PR is targeting galactic which is EOL. Can we close this PR or can you retarget this to ros2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Add Optical Frame Publisher
Summary
This is a utility that is used frequently enough, I think that it makes sense to include here. This transforms images (and optionally camera info) into the ROS coordinate conventions from those that gazebo uses.
I have written it as a component, which can take advantage of intraprocess communication where available.
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.