Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deadline and liveliness to the qos_overriding_options #608

Closed
norakon opened this issue Sep 13, 2024 · 2 comments
Closed

Add deadline and liveliness to the qos_overriding_options #608

norakon opened this issue Sep 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@norakon
Copy link
Contributor

norakon commented Sep 13, 2024

Hello,

I would like to request a feature enhancement for the ros_gz_bridge package. Currently, the package allows configuring the following Quality of Service (QoS) settings via parameters: Depth, Durability, History, and Reliability. This is very useful, but it would be even more beneficial if we could also configure the Deadline and Liveliness properties of QoS.

Feature Request:

Please add possibility to configure the QoS Deadline and Liveliness properties via the qos_overrides parameter.

Context and Use Case:

Configuring Deadline and Liveliness properties can be critical for applications with stringent real-time requirements or for ensuring reliable message delivery and processing in complex systems. Adding these parameters will enhance the flexibility of the ros_gz_bridge package, making it more adaptable to diverse scenarios and requirements.

Reference:

The currently allowed configurable properties can be seen in the qos_overriding_options in factory.hpp. I believe extending this to include Deadline and Liveliness would be a valuable addition.

@norakon norakon added the enhancement New feature or request label Sep 13, 2024
@norakon
Copy link
Contributor Author

norakon commented Sep 13, 2024

I took the liberty to add the missing qos policies here: norakon/ros_gz@ros2...extend_qos_overriding_options

@ahcorde
Copy link
Collaborator

ahcorde commented Sep 13, 2024

Do you mind to open a PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants