adds deadline and liveliness QoSPolicyKinds to qos_overriding_options #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Do you mind to sign the commit ? https://github.com/gazebosim/ros_gz/pull/609/checks?check_run_id=30112405607
Signed-off-by: nora <[email protected]>
norakon
force-pushed
the
extend_qos_overriding_options
branch
from
7295e3e
to
974d1e1
Compare
ahcorde
approved these changes
Sep 16, 2024
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
…#609) Signed-off-by: nora <[email protected]> Co-authored-by: nora <[email protected]> (cherry picked from commit 2d4a1a8)
ahcorde
pushed a commit
that referenced
this pull request
Sep 16, 2024
…#609) (#613) Signed-off-by: nora <[email protected]> Co-authored-by: nora <[email protected]> (cherry picked from commit 2d4a1a8) Co-authored-by: norakon <[email protected]>
Amronos
pushed a commit
to Amronos/ros_gz
that referenced
this pull request
Sep 18, 2024
…gazebosim#609) (gazebosim#613) Signed-off-by: nora <[email protected]> Co-authored-by: nora <[email protected]> (cherry picked from commit 2d4a1a8) Co-authored-by: norakon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses # 608
Simply adds Deadline and Liveliness to the qos_overriding_options.