Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport rendering test fixes from fortress to citadel #397

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Backport rendering test fixes from fortress to citadel #397

merged 2 commits into from
Oct 16, 2023

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes #393.

Summary

Backports #169, and #324 to citadel to fix rendering tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Rebase-and-Merge.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 16, 2023
@scpeters scpeters mentioned this pull request Oct 16, 2023
Closed
@scpeters scpeters merged commit 6b8b570 into ign-sensors3 Oct 16, 2023
11 of 12 checks passed
@scpeters scpeters deleted the scpeters/backport_test_fix branch October 16, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @ahcorde @iche033