-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package.xml #608
Add package.xml #608
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-physics7 #608 +/- ##
============================================
Coverage 78.32% 78.32%
============================================
Files 140 140
Lines 8069 8069
============================================
Hits 6320 6320
Misses 1749 1749 ☔ View full report in Codecov by Sentry. |
package.xml
Outdated
|
||
<depend>benchmark</depend> | ||
<depend>bullet</depend> | ||
<depend>dartsim</depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know dartsim uses this name in its package.xml
file, but I had added a colcon.pkg file to change its package name for colcon's purposes to DART
so that colcon-cmake
would recognize find_package(DART)
(see dartsim/dart#1389)
I haven't yet tried to build a workspace with gz-physics, dartsim, bullet and ODE, and we don't need to block on this, but I'm not sure building all those from source in the same workspace will work properly in this current form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I used colcon graph
and saw that gz-physics
didn't have a dependency on DART, so I've changed it in df390df
Before
DART +
gz-cmake3 +********* *****
gz-tools2 + * ***..*****
gz-utils2 +***.******.*.
gz-math7 + ***********
gz-plugin2 + ** *.**
gz-common5 + *** ****
gz-msgs10 + * *****
sdformat14 + * ***
gz-fuel_tools9 + *.
gz-physics7 + **
gz-rendering8 + ****
gz-transport13 +****
gz-gui8 + **
gz-sensors8 +**
gz-sim8 +*
gz-launch7 +
After
DART + * ..
gz-cmake3 +********* *****
gz-tools2 + * ***..*****
gz-utils2 +***.******.*.
gz-math7 + ***********
gz-plugin2 + ** *.**
gz-common5 + *** ****
gz-msgs10 + * *****
sdformat14 + * ***
gz-fuel_tools9 + *.
gz-physics7 + **
gz-rendering8 + ****
gz-transport13 +****
gz-gui8 + **
gz-sensors8 +**
gz-sim8 +*
gz-launch7 +
Signed-off-by: Addisu Z. Taddese <[email protected]>
🎉 New feature
Summary
Add
package.xml
based on dependencies found in.github/ci/packages
.This is to test out using vendor packages to provide Gazebo packages to ROS users (see gazebo-tooling/release-tools#1117).