Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Ignition #223

Merged
merged 4 commits into from
Aug 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ Deprecated code produces compile-time warnings. These warning serve as
notification to users that their code should be upgraded. The next major
release will remove the deprecated code.

## Gazebo Launch 6.X to 7.X

- Removed Ignition
- Removed the ignition include directory.
- Launch scripts must use the `<gz>` element.

## Gazebo Launch 5.X to 6.X

- The `ignition` namespace is deprecated and will be removed in future versions.
Expand Down
2 changes: 1 addition & 1 deletion examples/factory.gzlaunch
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<sdf version='1.6'>
<include>
<uri>https://fuel.ignitionrobotics.org/1.0/openrobotics/models/X2 UGV/1</uri>
<uri>https://fuel.gazebosim.org/1.0/openrobotics/models/X2 UGV/1</uri>
<plugin filename="gz-sim-diff-drive-system"
name="gz::sim::systems::DiffDrive">
<left_joint>front_left_wheel_joint</left_joint>
Expand Down
4 changes: 2 additions & 2 deletions examples/multi_factory.gzlaunch
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<sdf version='1.6'>
<include>
<uri>https://fuel.ignitionrobotics.org/1.0/openrobotics/models/X3 UAV Config 1</uri>
<uri>https://fuel.gazebosim.org/1.0/openrobotics/models/X3 UAV Config 1</uri>
</include>
</sdf>
</spawn>
Expand All @@ -20,7 +20,7 @@

<sdf version='1.6'>
<include>
<uri>https://fuel.ignitionrobotics.org/1.0/openrobotics/models/X1 Config 1</uri>
<uri>https://fuel.gazebosim.org/1.0/openrobotics/models/X1 Config 1</uri>
</include>
</sdf>
</spawn>
Expand Down
1 change: 0 additions & 1 deletion include/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
add_subdirectory(gz)
install(DIRECTORY ignition DESTINATION ${GZ_INCLUDE_INSTALL_DIR_FULL})
19 changes: 0 additions & 19 deletions include/ignition/launch.hh

This file was deleted.

19 changes: 0 additions & 19 deletions include/ignition/launch/Export.hh

This file was deleted.

19 changes: 0 additions & 19 deletions include/ignition/launch/Plugin.hh

This file was deleted.

48 changes: 0 additions & 48 deletions include/ignition/launch/config.hh

This file was deleted.

2 changes: 1 addition & 1 deletion plugins/sim_factory/SimFactory.hh
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace gz
/// spawned -->
/// <sdf version='1.6'>
/// <include>
/// <uri>https://fuel.ignitionrobotics.org/1.0/openrobotics/models/X2 UGV/1</uri>
/// <uri>https://fuel.gazebosim.org/1.0/openrobotics/models/X2 UGV/1</uri>
/// <!-- Publish robot state information -->
/// <plugin filename="gz-sim-state-publisher-system"
/// name="gz::sim::systems::StatePublisher"></plugin>
Expand Down
30 changes: 2 additions & 28 deletions src/Manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -679,14 +679,8 @@ bool ManagerPrivate::ParseConfig(const std::string &_config)
tinyxml2::XMLElement *root = xmlDoc.FirstChildElement("gz");
if (!root)
{
root = xmlDoc.FirstChildElement("ignition");
if (!root)
{
gzerr << "Invalid config file, missing `<gz>` element\n";
return false;
}
gzwarn << "The `<ignition>` element is deprecated and will be removed. "
<< "Please use `<gz>` instead." << std::endl;
gzerr << "Invalid config file, missing `<gz>` element\n";
return false;
}
// Keep the environment variables in memory. See manpage for putenv.
this->envs = this->ParseEnvs(root);
Expand Down Expand Up @@ -1111,26 +1105,6 @@ void ManagerPrivate::LoadPlugin(const tinyxml2::XMLElement *_elem)
else
pathToLib = systemPaths.FindSharedLibrary(file);

if (pathToLib.empty())
{
// TODO(CH3): Deprecated. Remove on ticktock.
// This tries to find one more time with IGN_LAUNCH_PLUGIN_PATH instead of
// GZ_LAUNCH_PLUGIN_PATH
systemPaths.SetPluginPathEnv("IGN_LAUNCH_PLUGIN_PATH");

systemPaths.AddPluginPaths(
gz::common::joinPaths(homePath, ".ignition", "gazebo", "plugins"));

pathToLib = systemPaths.FindSharedLibrary(file);

if (!pathToLib.empty())
{
gzwarn << "Found plugin [" << pathToLib
<< "] using deprecated environment variable [IGN_LAUNCH_PLUGIN_PATH]."
" Please use [GZ_LAUNCH_PLUGIN_PATH] instead." << std::endl;
}
}

if (pathToLib.empty())
{
gzerr << "Failed to find the path to library[" << file << "]. "
Expand Down
2 changes: 1 addition & 1 deletion src/Manager_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ TEST_F(ManagerTest, RunEmptyConfig)
}

/////////////////////////////////////////////////
TEST_F(ManagerTest, MissingIgnition)
TEST_F(ManagerTest, MissingGz)
{
std::string config =
"<executable name='sim'>"
Expand Down
32 changes: 0 additions & 32 deletions test/integration/deprecated_TEST.cc

This file was deleted.

4 changes: 2 additions & 2 deletions tutorials/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ necessary prerequisites followed by building from source.

```
sudo apt -y install \
$(sort -u $(find . -iname 'packages-'`lsb_release -cs`'.apt' -o -iname 'packages.apt' | grep -v '/\.git/') | sed '/ignition\|sdf/d' | tr '\n' ' ')
$(sort -u $(find . -iname 'packages-'`lsb_release -cs`'.apt' -o -iname 'packages.apt' | grep -v '/\.git/') | sed '/gz\|sdf/d' | tr '\n' ' ')
```

1. Install required Gazebo libraries
Expand Down Expand Up @@ -105,7 +105,7 @@ necessary prerequisites followed by building from source.

2. Install dependencies
```
brew install --only-dependencies ignition-launch<#>
brew install --only-dependencies gz-launch<#>
```
Be sure to replace `<#>` with a number value, such as 5 or 6, depending on
which version you need.
Expand Down