Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Ignition #223

Merged
merged 4 commits into from
Aug 26, 2023
Merged

Removed Ignition #223

merged 4 commits into from
Aug 26, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 26, 2023

🎉 New feature

This removes Ignition from gz-launch.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig marked this pull request as draft July 26, 2023 12:40
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #223 (ca5b40c) into main (76b4ba6) will increase coverage by 1.20%.
The diff coverage is 100.00%.

❗ Current head ca5b40c differs from pull request most recent head f0b1800. Consider uploading reports for the commit f0b1800 to get more accurate results

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   56.90%   58.10%   +1.20%     
==========================================
  Files           3        3              
  Lines         413      401      -12     
==========================================
- Hits          235      233       -2     
+ Misses        178      168      -10     
Files Changed Coverage Δ
src/Manager.cc 55.10% <100.00%> (+1.37%) ⬆️

Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo

examples/factory.gzlaunch Outdated Show resolved Hide resolved
Base automatically changed from 6-to-main-20230726 to main July 26, 2023 13:06
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig marked this pull request as ready for review August 2, 2023 12:28
@nkoenig nkoenig requested a review from mjcarroll August 2, 2023 12:35
@nkoenig
Copy link
Contributor Author

nkoenig commented Aug 23, 2023

One typo

Fixed.

@azeey azeey added beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic labels Aug 23, 2023
@azeey azeey merged commit 3919ae3 into main Aug 26, 2023
8 checks passed
@azeey azeey deleted the nkoenig/remove-ign branch August 26, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants