Allow use of operator-> with huffman::table::const_iterator
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlee
force-pushed
the
I2c9d14705bd5a0d8f7e562006913906d40c7fe86
branch
from
a59a5b8
to
115422e
Compare
oliverlee
changed the title
operator-> with huffman::table iteratoroperator-> with huffman::table::const_iterator
oliverlee
force-pushed
the
I2c9d14705bd5a0d8f7e562006913906d40c7fe86
branch
from
115422e
to
e004d4e
Compare
|
I didn't document much. The implementation of |
oliverlee
force-pushed
the
I2c9d14705bd5a0d8f7e562006913906d40c7fe86
branch
2 times, most recently
from
cce3ecc
to
52f27b3
Compare
garymm
reviewed
Jun 13, 2023
oliverlee
force-pushed
the
I2c9d14705bd5a0d8f7e562006913906d40c7fe86
branch
2 times, most recently
from
ee522c2
to
52f27b3
Compare
garymm
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
If this is blocking you from doing something else feel free to merge it in but I'd rather discuss it first, maybe next week.
- I'd like to understand it
- I don't think it's actually worth all the added code, given that the table const_iterator is just an implementation detail of our library.
Yeah let's wait. Hopefully I can convince you otherwise after chatting about it :) |
Replace use of `views::transform` with a custom view type `detail::base_view<V, B>` that casts a derived type (i.e. elements of view `V`) to base `B`. `detail::base_view<V, B>` requires the reference type of underlying view `V` be a true reference, thus `detail::base_view<V, B>::iterator` defines `operator->` to return a pointer to `B*`. resolves #49 Change-Id: I2c9d14705bd5a0d8f7e562006913906d40c7fe86
oliverlee
force-pushed
the
I2c9d14705bd5a0d8f7e562006913906d40c7fe86
branch
from
52f27b3
to
555ae92
Compare
garymm
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of
views::transformwith a custom view typedetail::base_view<V, B>that casts a derived type (i.e. elements ofview
V) to baseB.detail::base_view<V, B>requires the reference type of underlying viewVbe a true reference, thusdetail::base_view<V, B>::iteratordefines
operator->to return a pointer toB*.resolves #49
Change-Id: I2c9d14705bd5a0d8f7e562006913906d40c7fe86