-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow use of
operator-> with huffman::table iterator
Replace use of `views::transform` with a custom view type `detail::base_view<V, B>` that casts a derived type (i.e. elements of view `V`) to base `B`. `detail::base_view<V, B>` requires the reference type of underlying view `V` be a true reference, thus `detail::base_view<V, B>::iterator` defines `operator->` to return a pointer to `B*`. resolves #49 Change-Id: I2c9d14705bd5a0d8f7e562006913906d40c7fe86
- Loading branch information
Showing
4 changed files
with
199 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| #pragma once | ||
|
|
||
| #include <concepts> | ||
| #include <iterator> | ||
| #include <ranges> | ||
| #include <utility> | ||
|
|
||
| namespace gpu_deflate::huffman::detail { | ||
|
|
||
| /// A view of elements cast to a base class | ||
| /// @tparam V underlying view | ||
| /// @tparam B base class | ||
| /// | ||
| template <std::ranges::forward_range V, class B> | ||
| requires std::ranges::view<V> and | ||
| std::same_as<std::ranges::iterator_t<V>, std::ranges::sentinel_t<V>> and | ||
| std::derived_from<std::ranges::range_value_t<V>, B> | ||
| class base_view : public std::ranges::view_interface<base_view<V, B>> | ||
| { | ||
| // This is largely adapted from `transform_view` (or other views), although we | ||
| // apply some simplifications: | ||
| // * V must model `forward_range` instead of `input_range` | ||
| // * sentinel_t<V> is the same as iterator_t<V> | ||
| // | ||
| // https://eel.is/c++draft/range.transform | ||
|
|
||
| V base_{}; | ||
|
|
||
| public: | ||
| class iterator | ||
| { | ||
| using base_iterator = std::ranges::iterator_t<V>; | ||
| base_iterator base_{}; | ||
|
|
||
| public: | ||
| using iterator_category = | ||
| typename std::iterator_traits<base_iterator>::iterator_category; | ||
| using value_type = std::ranges::range_value_t<V>; | ||
| using reference = B&; | ||
| using pointer = B*; | ||
| using difference_type = std::ranges::range_difference_t<V>; | ||
|
|
||
| iterator() | ||
| requires std::default_initializable<base_iterator> | ||
| = default; | ||
| constexpr iterator(base_iterator current) : base_{std::move(current)} {} | ||
|
|
||
| constexpr auto base() const& noexcept -> const base_iterator& | ||
| { | ||
| return base_; | ||
| } | ||
| constexpr auto base() && -> base_iterator { return std::move(base_); } | ||
|
|
||
| constexpr auto operator*() const -> reference | ||
| { | ||
| return static_cast<reference>(*base_); | ||
| } | ||
| constexpr auto operator->() const -> pointer { return &**this; } | ||
|
|
||
| constexpr auto operator++() -> iterator& | ||
| { | ||
| ++base_; | ||
| return *this; | ||
| } | ||
| constexpr auto operator++(int) -> iterator | ||
| { | ||
| auto tmp = *this; | ||
| ++*this; | ||
| return tmp; | ||
| } | ||
|
|
||
| constexpr auto operator--() -> iterator& | ||
| requires std::ranges::bidirectional_range<V> | ||
| { | ||
| --base_; | ||
| return *this; | ||
| } | ||
| constexpr auto operator--(int) -> iterator | ||
| requires std::ranges::bidirectional_range<V> | ||
| { | ||
| auto tmp = *this; | ||
| --*this; | ||
| return tmp; | ||
| } | ||
|
|
||
| constexpr auto operator+=(difference_type n) -> iterator& | ||
| requires std::ranges::random_access_range<V> | ||
| { | ||
| base_ += n; | ||
| return *this; | ||
| } | ||
| constexpr auto operator-=(difference_type n) -> iterator& | ||
| requires std::ranges::random_access_range<V> | ||
| { | ||
| base_ -= n; | ||
| return *this; | ||
| } | ||
|
|
||
| constexpr auto operator[](difference_type n) const -> reference | ||
| requires std::ranges::random_access_range<V> | ||
| { | ||
| return static_cast<reference>(base_[n]); | ||
| } | ||
|
|
||
| friend constexpr auto | ||
| operator<=>(const iterator&, const iterator&) = default; | ||
|
|
||
| friend constexpr auto operator+(iterator i, difference_type n) -> iterator | ||
| requires std::ranges::random_access_range<V> | ||
| { | ||
| return i += n; | ||
| } | ||
| friend constexpr auto operator+(difference_type n, iterator i) -> iterator | ||
| requires std::ranges::random_access_range<V> | ||
| { | ||
| return i + n; | ||
| } | ||
|
|
||
| friend constexpr auto operator-(iterator i, difference_type n) -> iterator | ||
| requires std::ranges::random_access_range<V> | ||
| { | ||
| return i -= n; | ||
| } | ||
| friend constexpr auto | ||
| operator-(const iterator& x, const iterator& y) -> difference_type | ||
| requires std::ranges::random_access_range<V> | ||
| { | ||
| return x.base() - y.base(); | ||
| } | ||
| }; | ||
|
|
||
| base_view() requires std::default_initializable<V> = default; | ||
| constexpr explicit base_view(V base) : base_{std::move(base)} {} | ||
|
|
||
| constexpr auto base() const& -> V | ||
| requires std::copy_constructible<V> | ||
| { | ||
| return base_; | ||
| } | ||
| constexpr auto base() && -> V { return std::move(base_); } | ||
|
|
||
| constexpr auto begin() const -> iterator { return {base().begin()}; } | ||
| constexpr auto end() const -> iterator { return {base().end()}; } | ||
| }; | ||
|
|
||
| // Use of range_adaptor_clousure requires GCC 13 or LLVM > 16.0.0 | ||
| // While this isn't necessary, it does allow a simpler declaration of | ||
| // `base_view_` type in the `table` class template. | ||
|
|
||
| // namespace views { | ||
| // | ||
| // template <class B> | ||
| // struct base_raco : std::ranges::range_adaptor_closure<base_raco<B>> | ||
| //{ | ||
| // template <std::ranges::forward_range V> | ||
| // constexpr auto operator()(V v) const | ||
| // -> base_view<V, B> | ||
| // { | ||
| // return base_view<V, B>{v} | ||
| // } | ||
| //}; | ||
| // | ||
| // template <class B> | ||
| // inline constexpr auto base = base_raco<B>{}; | ||
| // | ||
| //} | ||
|
|
||
| } // namespace gpu_deflate::huffman::detail |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters