Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement workflow parameter validators. #19092

Draft
wants to merge 15 commits into
base: dev
Choose a base branch
from
Draft

Implement workflow parameter validators. #19092

wants to merge 15 commits into from

Commits on Nov 7, 2024

  1. Implement regex validators for text workflow parameter

    @jmchilton
    jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    efedf8b View commit details
    Browse the repository at this point in the history

  2. Split populate_model from tool class

    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    addb89f View commit details
    Browse the repository at this point in the history

  3. Remove redundant app argument from populate_model

    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    af96838 View commit details
    Browse the repository at this point in the history

  4. Use populate_model to build parameter config form 

    Which allows building repeats and conditionals.
    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b063c1c View commit details
    Browse the repository at this point in the history

  5. Improve validator help text

    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    50f74a3 View commit details
    Browse the repository at this point in the history

  6. Let populate_model set state 

    We don't need to replciate this logic just for workflow parameters.
    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fc62852 View commit details
    Browse the repository at this point in the history

  7. Allow setting default value for required parameter

    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    545d783 View commit details
    Browse the repository at this point in the history

  8. Fix type populate_model type annotation

    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7aaf3a0 View commit details
    Browse the repository at this point in the history

  9. Fix unit tests

    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    764deab View commit details
    Browse the repository at this point in the history

  10. Adjust to new Repeat signature

    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    59bf105 View commit details
    Browse the repository at this point in the history

  11. Default value making input optional is unfrotunately not backwards co… 

    …mpatible
    @mvdbeek @jmchilton
    mvdbeek authored and jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3add680 View commit details
    Browse the repository at this point in the history

  12. Fixes for rebase of 18781 (workflow regex validators).

    @jmchilton
    jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3db36b9 View commit details
    Browse the repository at this point in the history

  13. Adapt workflow parameter validator work to validator models.

    @jmchilton
    jmchilton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8a8fa85 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Improvements to workflow parameter validators. 

    - Allow specifying a min/max for integer and float parameters.
- Swap language from regex to "Regular Expression" and synchronize help with regular expression fields in rule builder.
- Extend regular expression help.
- Improve default message for in_range validator. Probably a reversion in some ways introduced with galaxyproject#19027.
    @jmchilton
    jmchilton committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ffb4030 View commit details
    Browse the repository at this point in the history

  2. Test fixes...

    @jmchilton
    jmchilton committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2507b03 View commit details
    Browse the repository at this point in the history