Implement workflow parameter validators. #19092
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
min_max_regex
branch
2 times, most recently
from
952cc64
to
8b3ae58
Compare
mvdbeek
reviewed
Nov 5, 2024
lib/galaxy/workflow/modules.py
Outdated
| if source_type == "regex": | ||
| form_validators.append( | ||
| { | ||
| "__index__": i, |
There was a problem hiding this comment.
Why do we we need the __index__ field ? I thought this was legacy stuff from way back ?
There was a problem hiding this comment.
Just felt safer since it is only used by the client UI. I tried dropping it though and everything seems fine still.
Which allows building repeats and conditionals.
We don't need to replciate this logic just for workflow parameters.
jmchilton
force-pushed
the
min_max_regex
branch
from
8b3ae58
to
dc63ce8
Compare
- Allow specifying a min/max for integer and float parameters. - Swap language from regex to "Regular Expression" and synchronize help with regular expression fields in rule builder. - Extend regular expression help. - Improve default message for in_range validator. Probably a reversion in some ways introduced with galaxyproject#19027.
jmchilton
force-pushed
the
min_max_regex
branch
from
dc63ce8
to
2507b03
Compare
|
The API test failure is legit - no clue why though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronized the working implementation in #18781 with the parameter models introduced in #19027. Extended it to include min/max on integer and float parameters and to synchronize language and help with regular expression inputs form the rule builder.
How to test the changes?
(Select all options that apply)
License