Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(BufferMesh): update unit test case of BufferMesh #1691

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

jtabibito
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 added test unit test ignore for release ignore for release labels Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (c573715) 60.84% compared to head (b300ac2) 60.95%.

❗ Current head b300ac2 differs from pull request most recent head 0b1bfd1. Consider uploading reports for the commit 0b1bfd1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
+ Coverage   60.84%   60.95%   +0.11%     
==========================================
  Files         386      386              
  Lines       19993    19993              
  Branches     2856     2856              
==========================================
+ Hits        12164    12186      +22     
+ Misses       6727     6709      -18     
+ Partials     1102     1098       -4     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 96ed793 into galacean:main Sep 1, 2023
5 checks passed
GuoLei1990 added a commit that referenced this pull request Sep 7, 2023
* main:
  Fixed an issue where animation playback skipped the first frame (#1734)
  Fix the bug when user change speed direction in event handler (#1692)
  test(PrimitiveMesh): update unit test case of `PrimitiveMesh` (#1684)
  test(BufferMesh): update unit test case of (#1691)

# Conflicts:
#	packages/core/src/ComponentsManager.ts
#	packages/core/src/animation/Animator.ts
GuoLei1990 added a commit to cptbtptpbcptdtptp/engine that referenced this pull request Sep 11, 2023
* main: (23 commits)
  Fix the boundary value of exitTime issue with crossFade (galacean#1695)
  test(Light): add unit test case of `Light` (galacean#1702)
  Add unit test case of `BlendShapeManager` (galacean#1704)
  test(BlendShape): add unit test case of BlendShape (galacean#1703)
  Fixed an issue where animation playback skipped the first frame (galacean#1734)
  Fix the bug when user change speed direction in event handler (galacean#1692)
  test(PrimitiveMesh): update unit test case of `PrimitiveMesh` (galacean#1684)
  test(BufferMesh): update unit test case of (galacean#1691)
  test(SkinnedMeshRenderer): update unit test case of `SkinnedMeshRenderer` (galacean#1690)
  test(MeshRenderer): update unit test case of `MeshRenderer` (galacean#1683)
  chore: fix scene loader (galacean#1711)
  Fix shader compatible issue (galacean#1718)
  Add physic unit test timeout (galacean#1717)
  "v1.0.0-beta.20"
  Fix `PhysicManager`  fixedTimeStep less than 0 bug (galacean#1715)
  Fix physx unit test (galacean#1714)
  Fix a series of physical system problems (galacean#1712)
  Fix avoid destroyed material error (galacean#1705)
  "v1.0.0-beta.19"
  fix: memory leak of Transform (galacean#1701)
  ...
@jtabibito jtabibito deleted the test/BufferMesh branch March 19, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release test unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants