Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort program if a subprocess fails #63

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jb-adams
Copy link
Member

My solution for #60

Essentially, checks that each shell subprocess launched by the program exited without an error. If a subprocess exited with an error, the offending step is output to the console, and the program exits without performing the remaining steps.

@tschaffter
Copy link
Collaborator

Note: CI fails because @jb-adams is pushing from a fork, in which case the GitHub Secrets defined in this repo are not available.

@jb-adams
Copy link
Member Author

jb-adams commented Nov 2, 2020

@tschaffter I added a COVERALLS_REPO_TOKEN env variable for building on my end. Will this cause the build on ga4gh fork to break once merged? If so, I'll remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants