Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing GA4GH service-info to DRS #310

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

susheel
Copy link
Member

@susheel susheel commented Jan 28, 2020

Resolves #309

@dglazer
Copy link
Member

dglazer commented Jan 28, 2020

@susheel, per the CONTRIBUTING guidelines, we only submit PRs to release branches, not to master. (The main reason is to make sure the Travis CI checks get run, including rebuilding the docs, in each branch -- that way we can be sure the change doesn't break anything, and confirm that the documentation matches the intent.)

@susheel susheel changed the base branch from master to release/v1.0.1 January 28, 2020 14:00
@susheel
Copy link
Member Author

susheel commented Jan 28, 2020

@dglazer Done. I have rebased this PR to release/v1.0.1

@dglazer
Copy link
Member

dglazer commented Jan 30, 2020

@susheel , I'm not an expert on the HubFlow process described in Contributing.MD, but I think the key parts are a) name your feature branch according to the required naming convention, and b) set it up to merge into develop (not a release branch, and not master). @briandoconnor can confirm.

One benefit of that is triggering the Travis CI checks; there are other benefits around the release process that I'm less familiar with.

@susheel susheel changed the base branch from release/v1.0.1 to develop January 30, 2020 15:19
@susheel
Copy link
Member Author

susheel commented Jan 30, 2020

Done.

@susheel susheel changed the title Adding GA4GH service-info to DRS Implementing GA4GH service-info to DRS Feb 5, 2020
@susheel
Copy link
Member Author

susheel commented Feb 5, 2020

GA4GH service-info has just tagged their release v1.0.0 which now makes this PR valid to merge, barring any build and test errors.

@jb-adams
Copy link
Member

Reviving this thread as getting /service-info in DRS has been discussed at the past few meetings.

@susheel it would be great if you are still available to work on this PR. The spec was recently migrated from Swagger to OpenAPI, so now there are some merge conflicts. Do you have the bandwidth to update your branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants