Try to fix GLEW build

[o01eg]

Should help with GLEW build issue #67 and #88 (comment) but ensuring pass correct architecture value.

[geoffthemedio]

No change as far as I can tell. glew.lib is still 740 KB and I get linker errors building GG.

SDK build log attached... GLEW stuff starts at line 1978 Creating directories for 'glew'...
sdk_master_build.txt

[o01eg]

FreeType chooses compiler:

  Performing configure step for 'freetype'
  CMake Deprecation Warning at CMakeLists.txt:78 (cmake_minimum_required):
    Compatibility with CMake < 2.8.12 will be removed from a future version of
    CMake.
  
    Update the VERSION argument <min> value or use a ...<max> suffix to tell
    CMake that the project does not need compatibility with older versions.
  
  
  -- Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.19043.
  -- The C compiler identification is MSVC 19.29.30137.0
  -- The CXX compiler identification is MSVC 19.29.30137.0
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x86/cl.exe - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x86/cl.exe - skipped
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done

GLEW chooses compiler:

  Performing configure step for 'glew'
  -- Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.19043.
  -- The C compiler identification is MSVC 19.29.30137.0
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done

[geoffthemedio]

CMakeCache.txt still has /machine:x64, as does the .sln

[o01eg]

Could you upload entire CMakeCache.txt?

[geoffthemedio]

from build\glew-prefix\src\glew-build
CMakeCache.txt

from build
CMakeCache.txt

[o01eg]

Toolset and platform aren't passed.

//Name of generator.
CMAKE_GENERATOR:INTERNAL=Visual Studio 16 2019
//Generator instance identifier.
CMAKE_GENERATOR_INSTANCE:INTERNAL=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community
//Name of generator platform.
CMAKE_GENERATOR_PLATFORM:INTERNAL=
//Name of generator toolset.
CMAKE_GENERATOR_TOOLSET:INTERNAL=

//Name of generator.
CMAKE_GENERATOR:INTERNAL=Visual Studio 16 2019
//Generator instance identifier.
CMAKE_GENERATOR_INSTANCE:INTERNAL=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community
//Name of generator platform.
CMAKE_GENERATOR_PLATFORM:INTERNAL=Win32
//Name of generator toolset.
CMAKE_GENERATOR_TOOLSET:INTERNAL=v142

Does it have some verbosity settings?

[o01eg]

I also add commit to set those values differently

[geoffthemedio]

Does it have some verbosity settings?

Not sure what "it" is.

[geoffthemedio]

No change in glew.lib size or GG link errors.

[geoffthemedio]

...
CMakeCache.txt
CMakeCache.txt

[o01eg]

Raised minimum CMake version to 3.7 and use SOURCE_SUBDIR option for CMake external project. As I seen in build logs it correctly choose compiler https://github.com/o01eg/freeorion-sdk/runs/6485341097?check_suite_focus=true

[o01eg]

@Vezzra Does MacOS have CMake 3.7?

[geoffthemedio]

Looks like CMake 3.7 was released near the end of 2018.

[geoffthemedio]

I maybe wasn't actually using the modified versions you were uploading... I did the clone using the URL from the "Code" drop-button at the top of the page for the branch, but I think that defaults to your master branch, not the modified branch for the pull request (ie. the branch whose URL I was at). So possibly one of the earlier fixes could have worked?

[o01eg]

I suppose latest solution with SOURCE_SUBDIR is cleaner

[o01eg]

Correct compiler now:

2022-05-18T12:09:40.6785810Z   Performing configure step for 'glew'
2022-05-18T12:09:41.9943305Z   -- The C compiler identification is MSVC 19.16.27048.0
2022-05-18T12:09:42.0269121Z   -- Detecting C compiler ABI info
2022-05-18T12:09:42.9053504Z   -- Detecting C compiler ABI info - done
2022-05-18T12:09:42.9076628Z   -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.16.27023/bin/HostX64/x86/cl.exe - skipped

[geoffthemedio]

FreeOrion builds also work.

[o01eg]

Oh, FreeOrion itself requires CMake 3.8 so I suppose MacOS definitely build this SDK too.

[Vezzra]

@o01eg

Does MacOS have CMake 3.7?

$ cmake --version
cmake version 3.14.5

Yes 😃