-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK Python to 3.9.10 #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok AFAICT.
Did you try to build freeorion with it on Windows and MacOS? |
Oh, you want me to test it - no, I didn't have the time for that yet. Will try to get around to it next week... |
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok, tell me when you're done with checking the patches, then I'll try again. |
@Vezzra Could you try again? I reimported patches to python-cmake git, rebased them and reformatted them as patches. |
Also, could we make something with broken CI here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patching the Python cmake files seems to work now, but the subsequent cmake configure step fails with this error:
CMake Error at CMakeLists.txt:870 (endif):
endif An ENDIF command was found outside of a proper IF ENDIF structure.
Or its arguments did not match the opening IF command.
Complete cmake console output attached:
cmake_output.txt.zip
Here is the cmake file the error message refers to (I think). There is a lonely |
Found mismatched if-endif. Fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SDK builds successfully now, but I can't build FO master with that SDK. It fails during the cmake configure step, cmake output is this:
-- Setting build type to 'Release' as none was specified.
-- Build type CMAKE_BUILD_TYPE set to Release
-- The C compiler identification is AppleClang 11.0.0.11000033
-- The CXX compiler identification is AppleClang 11.0.0.11000033
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Use CCache for Xcode called with: ccache program
-- Performing Test NOT_GNU_CXX_BUG_94190
-- Performing Test NOT_GNU_CXX_BUG_94190 - Success
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Found PythonInterp: /usr/local/bin/python3 (found suitable version "3.8.3", minimum required is "3.6")
-- Found PythonLibs: /Library/Frameworks/Python.framework/Versions/3.8/lib/libpython3.8.dylib (found suitable version "3.8.3", minimum required is "3.6")
-- Python library version detected 3.8.3
-- Boost python version 38
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:254 (find_package)
-- Boost version: 1.74.0
-- Found the following Boost libraries:
-- filesystem
-- iostreams
-- locale
-- log
-- log_setup
-- serialization
-- system
-- thread
-- regex
-- date_time
-- chrono
-- atomic
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:266 (find_package)
-- Boost version: 1.74.0
-- Found the following Boost libraries:
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:270 (find_package)
CMake Error at cmake/FindBoost.cmake:2174 (message):
Unable to find the requested Boost libraries.
Boost version: 1.74.0
Boost include path: /Users/user/SoftwareProjekte/FO/main/build/dep/include
Could not find the following Boost libraries:
boost_python3
No Boost libraries were found. You may need to set BOOST_LIBRARYDIR to the
directory containing Boost libraries or BOOST_ROOT to the location of
Boost.
Call Stack (most recent call first):
CMakeLists.txt:270 (find_package)
-- Found ZLIB: /Users/user/SoftwareProjekte/FO/main/build/dep/lib/libz.a (found version "1.2.11")
-- Found SDL: /Users/user/SoftwareProjekte/FO/main/build/dep/Frameworks/SDL2.framework (found version "2.0.12")
-- Found Freetype: /Users/user/SoftwareProjekte/FO/main/build/dep/lib/libfreetype.a (found version "2.9.0")
-- Found OpenGL: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/OpenGL.framework
-- Found OpenAL: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/OpenAL.framework
-- Found Ogg: /Users/user/SoftwareProjekte/FO/main/build/dep/Frameworks/ogg.framework
-- Found Vorbis: /Users/user/SoftwareProjekte/FO/main/build/dep/Frameworks/vorbis.framework
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
GG/CMakeLists.txt:66 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
GG/CMakeLists.txt:66 (find_package)
CMake Warning at cmake/FindBoost.cmake:924 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/FindBoost.cmake:1046 (_Boost_COMPONENT_DEPENDENCIES)
cmake/FindBoost.cmake:1736 (_Boost_MISSING_DEPENDENCIES)
GG/CMakeLists.txt:66 (find_package)
-- Boost version: 1.74.0
-- Found the following Boost libraries:
-- filesystem
-- regex
-- system
-- Found GLEW: /Users/user/SoftwareProjekte/FO/main/build/dep/include
-- Found PNG: /Users/user/SoftwareProjekte/FO/main/build/dep/lib/libpng.a (found version "1.6.37")
Build number matches build number in existing Version.cpp, skip regenerating it
Build number matches build number in existing Version.cpp, skip regenerating it
Building v0.4.10+ build 2022-05-09.3abfde4
-- Could NOT find CPPCheck (missing: CPPCHECK_EXECUTABLE)
-- Could NOT find Flake8 (missing: FLAKE8_EXECUTABLE)
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
INSTALL TARGETS - target freeorion has RESOURCE files but no RESOURCE DESTINATION.
-- Configuring incomplete, errors occurred!
See also "/Users/user/SoftwareProjekte/FO/main/build/CMakeFiles/CMakeOutput.log".
@Vezzra It found incorrect python installation. Could you point it to 3.9 python with -DPYTHON_EXECUTABLE ? |
Ah, ok. Tried that now, however, I didn't use I ran the test on my Mac, do you need me to do that test also on Windows? |
Yes, but I suppose it will be simpler as Windows doesn't tend to have system-wide installed python. |
On Windows, building the SDK seems to work, but the resulting zip is slightly oddly named: FreeOrionSDK_12_MSVC-v142-.zip |
I tried bulding the SDK and then FreeOrion in x64 mode, and it seems to work. Just had to tweak the FreeOrion MSVC project files somewhat. Maybe that's the solution going forward? Switch to x64 builds? |
@geoffthemedio I've opened PR to fix possible choose of wrong architecture in GLEW #90 |
28b8429
to
bd87b7b
Compare
If building FO(with Python 3.6) on Windows 11 with VS 22, there is needed 32bit Python and compiling with VS Code needs choosing VS compiler version amd64_x86 (that's compiling on 64bit architecture for 32bit app)... But 32bit version of compilers and its testing for production is probably no more so tested including recent problems on Windows Server 2022 when were present various malfunctions in practice... MacOS problems could maybe resolved by switching MacOS to version 11 instead of 10.something(10.15?)... There is already version MacOS 12 in beta, which maybe next year will be actual, who knows... https://github.com/actions/virtual-environments |
SDK builds seemingly OK. Building FreeOrion with CMake gives errors:
|
That because I set |
This comment was marked as outdated.
This comment was marked as outdated.
Release made with this changes https://github.com/o01eg/freeorion-sdk/releases/tag/v14 |
Updated branch macos-python-no-framework for it. Also made artifacts from it for MacOS: https://github.com/o01eg/freeorion/actions/runs/4676648333 |
builds OK with CMake when specifying the python pathes. didn't try without specifying them. |
Nice, wait for @Vezzra for result. I've updated minimum MacOS version for boost also #107 (review) |
@Vezzra May be only test if artifact works. |
Ok, I did test it anyway, and I get errors now. I can build the SDK, but building FO with that SDK fails. Build logs: build_logs.zip |
@Vezzra I've add fixes to my branch macos-python-no-framework |
I propose to release SDK after merging this PR. |
Any PRs in the main freeorion repo that need to get merged into master for master to successfully build and run with the new version of the SDK? |
@Vezzra I've opened PR: freeorion/freeorion#4482 |
No description provided.