Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont send mail for other notifications yet #1720

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: dont send mail for other notifications yet #1720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions helpdesk/helpdesk/doctype/hd_notification/hd_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,14 @@
}

def after_insert(self):
frappe.sendmail(
recipients=self.user_to,
subject="New notification",
message=self.format_message(),
template="notification",
args=self.get_args(),
)
if self.notification_type == "Mention":
frappe.sendmail(

Check warning on line 55 in helpdesk/helpdesk/doctype/hd_notification/hd_notification.py

View check run for this annotation

Codecov / codecov/patch

helpdesk/helpdesk/doctype/hd_notification/hd_notification.py#L54-L55 

Added lines #L54 - L55 were not covered by tests
recipients=self.user_to,
subject="New notification",
message=self.format_message(),
template="notification",
args=self.get_args(),
)

def on_update(self):
refetch_resource("Notifications")
Loading