Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont send mail for other notifications yet #1720

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

sumitbhanushali
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 2.58%. Comparing base (8800411) to head (c864451).
Report is 4 commits behind head on main.

Files Patch % Lines
...elpdesk/doctype/hd_notification/hd_notification.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1720      +/-   ##
========================================
- Coverage   2.59%   2.58%   -0.02%     
========================================
  Files         59      59              
  Lines       1926    1935       +9     
========================================
  Hits          50      50              
- Misses      1876    1885       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumitbhanushali sumitbhanushali merged commit 56e0720 into frappe:main Mar 14, 2024
6 of 8 checks passed
@sumitbhanushali sumitbhanushali deleted the mail_fix branch March 14, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant