Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves finger collision geometries to the finger joints #151

Closed

Conversation

rickstaa
Copy link
Contributor

@rickstaa rickstaa commented Aug 18, 2021

This commit moves the finger collision geometries to the finger joints. This was done to prevent errors in third party libraries. Moveit for example expects a collision geometry in each joint that can be controlled. You can see this behaviour by running the panda_moveit_config demo.launch launch file. If the old description is used moveIt throws the following errors:

[ WARN] [1629295377.872753565]: Link panda_leftfinger has visual geometry but no collision geometry. Collision geometry will be left empty. Fix your URDF file by explicitly specifying collision geometry.
[ WARN] [1629295377.872794348]: Link panda_rightfinger has visual geometry but no collision geometry. Collision geometry will be left empty. Fix your URDF file by explicitly specifying collision geometry.

Old collision meshes

Safety distance 0.03

Open state:

image

Closed state:

image

Safety distance 0.0

image

New collision meshes

Safety distance 0.03

image

Safety distance 0.0

image

This commit moves the finger collision geometries to the finger joints.
This was done to prevent errors in third party libaries. Moveit for
example expects a collision geometry in each joint that can be
controlled.
@rhaschke
Copy link
Contributor

I agree with @rickstaa that the collision volumes of the fingers should be attached to the finger links, but not to the hand link.
As far as I understand the coarse collision volumes (from spheres and cylinders) are the ones used internally for self-collision checking. As such, they shouldn't affect too much collision checking with the environment. However, particularly the hand collision models are extremely coarse:
image

I suggest using thin cylinders to model the fingers. Also, the big cylinder around the hand base should be decreased in size, such that the collision geometry can be employed to actually plan grasps! Currently, one would need to disable collision for the full hand to allow grasping of objects, which doesn't increase safety!

@rickstaa
Copy link
Contributor Author

rickstaa commented Nov 9, 2021

Closed as this is implemented in #188.

@rickstaa rickstaa closed this Nov 9, 2021
@rickstaa rickstaa deleted the move_finger_collision_geometry branch November 9, 2021 14:46
@rickstaa rickstaa restored the move_finger_collision_geometry branch November 22, 2021 20:08
@rickstaa rickstaa deleted the move_finger_collision_geometry branch December 7, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants