Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate user settings variables outside of UserSettings #1804

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Sep 25, 2024

This is the PR for v2.6.1. It's ready to merge, but we should only do it after 2.6.0 is released.

closes #1786
closes #1787
closes #1805

Checklist before merging

  • I released v2.6.0
  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 25, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 1.0 0.80 0.0 0.0
power 0.8 0.9 0.89 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.3 11.5 0.90 0.6 0.6
power 386.9 423.4 0.91 389.0 389.0
dataset 152.6 165.0 0.92 145.6 145.6
project 46.7 52.6 0.89 50.9 50.9
job 27.1 29.9 0.91 35.3 35.3

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 7.9 0.84 2.2 2.2
power 133.2 145.8 0.91 652.0 652.0
dataset 135.0 148.8 0.91 904.8 904.8
project 44.0 48.8 0.90 283.7 283.7
job 36.4 43.5 0.84 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.9 9.1 0.87 0.1 0.1
power 8.4 8.9 0.94 0.1 0.1
dataset 7.8 8.9 0.88 0.1 0.1
project 9.6 10.9 0.88 2.3 2.3
job 7.7 8.6 0.90 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 14.3 13.1 1.09 0.8 0.8
power 24.4 27.0 0.90 27.2 27.2
dataset 19.2 21.6 0.89 15.8 15.8
project 22.4 24.5 0.91 19.9 19.9
job 11.7 12.3 0.95 0.8 0.8

POST /api/v2/project/3/dataset/420/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 148.8 158.2 0.94 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.2 5.4 0.96 0.2 0.2
power 5.0 5.3 0.94 0.2 0.2
dataset 5.0 5.3 0.94 0.2 0.2
project 5.1 5.1 1.00 0.2 0.2
job 5.1 5.2 0.98 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 263.0 264.7 0.99 0.2 0.2

Copy link

github-actions bot commented Sep 25, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  config.py
  fractal_server/app/models
  security.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa changed the title Deprecate user settings variables outside of UserSettings [DO NOT MERGE] Deprecate user settings variables outside of UserSettings Sep 25, 2024
@tcompa tcompa marked this pull request as draft September 25, 2024 09:25
@tcompa tcompa changed the title [DO NOT MERGE] Deprecate user settings variables outside of UserSettings Deprecate user settings variables outside of UserSettings Sep 26, 2024
@tcompa tcompa marked this pull request as ready for review September 26, 2024 07:17
@tcompa tcompa merged commit cc97803 into main Sep 26, 2024
20 checks passed
@tcompa tcompa deleted the 1786-deprecate-use-of-users-slurm_user-cache_dir-and-slurm_accounts branch September 26, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants