Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use of user's slurm_user, cache_dir and slurm_accounts #1786

Closed
tcompa opened this issue Sep 19, 2024 · 0 comments · Fixed by #1804
Closed

Deprecate use of user's slurm_user, cache_dir and slurm_accounts #1786

tcompa opened this issue Sep 19, 2024 · 0 comments · Fixed by #1804
Assignees
Labels
user_settings v2.6.1 Things that should happen in the release immediately after 2.6.0

Comments

@tcompa
Copy link
Collaborator

tcompa commented Sep 19, 2024

As part of version 2.6.0, the new ground truth for these parameters will be the values stored in the new user_settings table.

We cannot drop the user-table columns in 2.6.0, because the version update will need to also update data, as in:

  1. Update fractal-server version to 2.6.0
  2. Run set-db script, which applies schema migrations (and creates user-settings table)
  3. Run update-db-data script, which creates settings for each user (and fills them with current values - where applicable)
  4. You are now in a state where you could run a job, and it would use the new user-settings values. In this same state, the API for viewing/changing user settings is already in place, while the API for the old user attributes is already gone.
  5. Update fractal-server version to 2.6.1 (note: we expect this to take place right away, during the same maintenance session)
  6. Run set-db script, which removes old columns from user table (and also implements Make UserOAuth.user_settings_id required #1781)

The current issue, like #1781, will be implemented and merged for 2.6.1

@tcompa tcompa changed the title Deprecate use of user slurm_user, cache_dir and slurm_accounts Deprecate use of user's slurm_user, cache_dir and slurm_accounts Sep 19, 2024
@tcompa tcompa added the v2.6.1 Things that should happen in the release immediately after 2.6.0 label Sep 19, 2024
@tcompa tcompa mentioned this issue Sep 19, 2024
31 tasks
@ychiucco ychiucco linked a pull request Sep 25, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user_settings v2.6.1 Things that should happen in the release immediately after 2.6.0
Projects
Development

Successfully merging a pull request may close this issue.

2 participants