Task 52 #90
Merged
Task 52 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
reviewed
Jul 24, 2024
nomeata
commented
Jul 27, 2024
lakefile.lean
Outdated
Comment on lines
35
to
37
| require loogle from git | ||
| "https://github.com/nomeata/loogle.git" @ "master" | ||
|
|
There was a problem hiding this comment.
Of course I’ll remove this from this branch when and if this PR is getting closer to being merged.
fpvandoorn
reviewed
Jul 29, 2024
| next => simp | ||
| next z => | ||
| simp only [Nat.cast_inj, Nat.cast_le] | ||
| -- no single tactic for goal `∀ x < n, ¬z = x) ↔ n ≤ z`? |
There was a problem hiding this comment.
forall_lt_iff_le is close, but not quite there...
|
Ok, for a quick-merge-cleanup-later this might be just about viable now. |
|
Thanks for the cleanup, I was a bit in a rush, it seems. Also forgot to change |
|
No worries. The standards here are much lower than Mathlib, so when you have time, please make a follow-up PR fixing it :-) |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very first steps. Some things were easy generalization of code that was already there. Left some comments about things I'll have to think about.