Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #999

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update README.md #999

merged 1 commit into from
Oct 25, 2023

Conversation

esthersweon
Copy link
Contributor

Public-Facing Changes

  • Add logo to README

jtbandes
jtbandes approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider float="right" as well.

@esthersweon esthersweon merged commit c687014 into main Oct 25, 2023
24 of 25 checks passed
@esthersweon esthersweon deleted the esther/logo branch October 25, 2023 18:05
@esthersweon
Copy link
Contributor Author

@jtbandes - Left alone to keep it near the heading.

@ocin-rye - We had an outdated Linear ticket re: redesigning this README. I resurrected it to at least add the logo image, but if you had short-term changes we could make, I can implement them.

@ocin-rye
Copy link
Contributor

@ocin-rye - We had an outdated Linear ticket re: redesigning this README. I resurrected it to at least add the logo image, but if you had short-term changes we could make, I can implement them.

Is there a short tagline for MCAP? If so, I could create a header similar to the one used for studio's repo. Or maybe we use a version of the social graphic:
Logo and Name - 16_9 (1)

pezy pushed a commit to pezy/mcap that referenced this pull request Jan 11, 2024
@esthersweon @pezy
Update README.md (foxglove#999)
1dfc7e8 
### Public-Facing Changes

- Add logo to README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

@james-rms james-rms Awaiting requested review from james-rms

@achim-k achim-k Awaiting requested review from achim-k

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esthersweon @ocin-rye @jtbandes