Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/mcap: Fix scenario where schemaID equals 0 #992

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

StarCsu
Copy link
Contributor

@StarCsu StarCsu commented Oct 11, 2023

Public-Facing Changes

mcap specification explains schema id that it must be not zero,and go cli has zero-check,The picture is as follows:

img_v2_8730037e-0fbf-4014-8df4-14b4113821eg

Description

schema's documnet of website is https://mcap.dev/spec;

image

so i add this judgment that schema can't not zero,but I'm not sure if this merging operation is reasonable;

@jtbandes jtbandes requested a review from wkalt October 11, 2023 22:34
@wkalt
Copy link
Contributor

wkalt commented Nov 2, 2023

@StarCsu thanks, I think we should take this patch. However, are all the changes in go.work.sum necessary?

@StarCsu
Copy link
Contributor Author

StarCsu commented Nov 3, 2023

@StarCsu thanks, I think we should take this patch. However, are all the changes in go.work.sum necessary?

yes,go.work.sum is used for project version verification, which needs to be updated, and the go test pipeline has been verified and passed;

@wkalt
Copy link
Contributor

wkalt commented Nov 3, 2023

@StarCsu What did you run to update the file? I understand it won't cause tests to fail or anything, and if this is something we just should have run previously I'm fine to commit it. But changes to that file can also come in from local modifications in the user's environment, so I just want to make sure those changes are actually relevant to this project.

@StarCsu
Copy link
Contributor Author

StarCsu commented Nov 6, 2023

@StarCsu What did you run to update the file? I understand it won't cause tests to fail or anything, and if this is something we just should have run previously I'm fine to commit it. But changes to that file can also come in from local modifications in the user's environment, so I just want to make sure those changes are actually relevant to this project.

i understand your means,go.sum's changes is not my local user's environment,if everyone use this cmd that is "go mod tidy",it will become current content;

@wkalt Considering that I am not completely dependent on this go.work.sum, I rolled back this file.

@defunctzombie defunctzombie requested review from james-rms and removed request for wkalt January 23, 2024 22:54
Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-rms any other issues with this PR. It LGTM. If you are 👍 please merge.

@james-rms james-rms merged commit 24a6c39 into foxglove:main Feb 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants