go/cli: Coalesce identical channels by default #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
force-pushed
the
achim/fg-4945-mcap-option-for-merge-to-attempt-to-coalesce-channelsschemas
branch
from
5bff47e
to
9254f87
Compare
jtbandes
reviewed
Oct 10, 2023
|
@wkalt @james-rms thoughts? |
|
Friendly ping @wkalt / @james-rms / @narasaka |
james-rms
reviewed
Oct 30, 2023
james-rms
reviewed
Oct 30, 2023
go/cli/mcap/cmd/merge.go
Outdated
| } | ||
|
|
||
| hash := hasher.Sum(nil) | ||
| return hex.EncodeToString(hash) |
There was a problem hiding this comment.
seems odd to me that we store the hash as a string rather than a fixed size value - won't block the PR, just seems odd.
There was a problem hiding this comment.
I feel like channelIdByHash should key off the result of hasher.Sum().
There was a problem hiding this comment.
Done. Should I do the same for the schemaIDByHash map ?
There was a problem hiding this comment.
Yep, that would be good.
Changes the default behavior of `mcap merge` to automatically coalesce identical channels. Channels are considered identical when their topic, schema, message encoding and metadata equals. One can force coalescing of channels with different metadata with `--coalesce-channels force`. Channel coalescing can also be completely disabled with `--coalesce-channels none`.
achim-k
force-pushed
the
achim/fg-4945-mcap-option-for-merge-to-attempt-to-coalesce-channelsschemas
branch
from
6fce3dc
to
eb8491f
Compare
james-rms
approved these changes
Nov 2, 2023
achim-k
deleted the
achim/fg-4945-mcap-option-for-merge-to-attempt-to-coalesce-channelsschemas
branch
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes go/cli: Coalesce identical channels by default ### Description Changes the default behavior of `mcap merge` to automatically coalesce identical channels. Channels are considered identical when their topic, schema, message encoding and metadata equals. One can force coalescing of channels with different metadata with `--coalesce-channels force`. Channel coalescing can also be completely disabled with `--coalesce-channels none`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
go/cli: Coalesce identical channels by default
Description
Changes the default behavior of
mcap mergeto automatically coalesce identical channels. Channels are considered identical when their topic, schema, message encoding and metadata equals. One can force coalescing of channels with different metadata with--coalesce-channels force. Channel coalescing can also be completely disabled with--coalesce-channels none.