Fix ROS 2 message equality check #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Seems fine. I am not an expert in __slots__. For reference, I believe this is the original implementation which this dynamic generation code was adapted from:
https://github.com/ros/genpy/blob/f70658f2200dfb7c98e99e9cf15be61cfaa1a432/src/genpy/message.py#L419
achim-k
deleted the
achim/fg-4775-ros2-decoded-messages-__eq__-always-returns-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Fix ROS 2 message equality check
Description
Use a custom comparison function that compares messages by their
__slots__fields.Fixes #959
Resolves FG-4775