Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Properly support --name parameter on add attachment #953

Merged
merged 1 commit into from
Aug 25, 2023
Merged

CLI: Properly support --name parameter on add attachment #953

merged 1 commit into from
Aug 25, 2023

Conversation

wkalt
Copy link
Contributor

@wkalt wkalt commented Aug 25, 2023

Previously this parameter did not function. Not sure if it never functioned or if we lost the support at some point.

CLI: Properly support --name parameter on add attachment
7fa386b 
Previously this parameter did not function. Not sure if it never
functioned or if we lost the support at some point.
@wkalt
Copy link
Contributor Author

wkalt commented Aug 25, 2023

Evidence:

[~/work/mcap/go/cli/mcap] (task/fix-bug-support-attachment-name) $ mcap add attachment demo.mcap --name "my attachment" --file go.mod
[~/work/mcap/go/cli/mcap] (task/fix-bug-support-attachment-name) $ mcap list attachments demo.mcap
  name              media type                log time             creation time        content length  offset
  mcap-block.pprof  application/octet-stream  1686843808218678534  1682544823368907613  1826            61480486
  mcap-block.pprof  application/octet-stream  1686843811435487323  1682544823368907613  1826            61482397
  mcap-block.pprof  application/octet-stream  1686843812606199348  1682544823368907613  1826            61484308
  my attachment     application/octet-stream  1692924503611175852  1692898021661617461  2617            61486219

@wkalt wkalt requested a review from jtbandes August 25, 2023 00:48
@wkalt wkalt merged commit ae272c1 into main Aug 25, 2023
24 checks passed
@wkalt wkalt deleted the task/fix-bug-support-attachment-name branch August 25, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkalt @jtbandes