Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add og-image for mcap.dev site #940

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add og-image for mcap.dev site #940

merged 1 commit into from
Aug 3, 2023

Conversation

esthersweon
Copy link
Contributor

Public-Facing Changes

  • Add og-image for mcap.dev site

@esthersweon esthersweon enabled auto-merge (squash) August 2, 2023 00:28
bryfox
bryfox approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@bryfox bryfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Presumably twitter et al post-process this as needed, so we could use a higher-res version with less compression if we wanted?

@esthersweon esthersweon merged commit ec08e50 into main Aug 3, 2023
24 checks passed
@esthersweon esthersweon deleted the esther/fg-4461 branch August 3, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryfox bryfox bryfox approved these changes

@amacneil amacneil Awaiting requested review from amacneil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esthersweon @bryfox